sb,soc/intel: Drop OSYS from GNVS

The value should be set by OSPM using some combination of
_OSI() queris in the \_SB._INI() method.

To maintain previous behaviour with this commit, boards where
GNVS osys initialisation was removed now do the same in ASL.

Change-Id: Id4957b12a72fbf7fa988e7ff039e47abcc072e1c
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49353
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/acpi/dsdt_top.asl

@@ -8,5 +8,8 @@
 #include <vendorcode/google/chromeos/acpi/chromeos.asl>
 #endif
 
+/* Operating system enumeration. */
+Name (OSYS, 0)
+
 /* Power state (AC = 1) */
 Name (PWRS, One)

src/mainboard/acer/g43t-am3/acpi_tables.c

@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_gnvs.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
-	gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
-}

src/mainboard/acer/g43t-am3/dsdt.asl

@@ -11,6 +11,8 @@ DefinitionBlock(
 )
 {
 	#include <acpi/dsdt_top.asl>
+
+	OSYS = 2002
 	// global NVS and variables
 	#include <southbridge/intel/common/acpi/platform.asl>
 	#include <southbridge/intel/i82801jx/acpi/globalnvs.asl>

src/mainboard/asus/p5qc/acpi_tables.c

@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_gnvs.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
-	gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
-}

src/mainboard/asus/p5qc/dsdt.asl

@@ -11,6 +11,8 @@ DefinitionBlock(
 )
 {
 	#include <acpi/dsdt_top.asl>
+
+	OSYS = 2002
 	// global NVS and variables
 	#include <southbridge/intel/common/acpi/platform.asl>
 	#include <southbridge/intel/i82801jx/acpi/globalnvs.asl>

src/mainboard/asus/p5ql-em/acpi_tables.c

@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_gnvs.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
-	gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
-}

src/mainboard/asus/p5ql-em/dsdt.asl

@@ -13,6 +13,8 @@ DefinitionBlock(
 )
 {
 	#include <acpi/dsdt_top.asl>
+
+	OSYS = 2002
 	// global NVS and variables
 	#include <southbridge/intel/common/acpi/platform.asl>
 	#include <southbridge/intel/i82801jx/acpi/globalnvs.asl>

src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c

@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_gnvs.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
-	gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
-}

src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl

@@ -11,6 +11,8 @@ DefinitionBlock(
 )
 {
 	#include <acpi/dsdt_top.asl>
+
+	OSYS = 2002
 	// global NVS and variables
 	#include <southbridge/intel/common/acpi/platform.asl>
 	#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>

src/mainboard/intel/dg43gt/acpi_tables.c

@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_gnvs.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
-	gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
-}

src/mainboard/intel/dg43gt/dsdt.asl

@@ -11,6 +11,8 @@ DefinitionBlock(
 )
 {
 	#include <acpi/dsdt_top.asl>
+
+	OSYS = 2002
 	// global NVS and variables
 	#include <southbridge/intel/common/acpi/platform.asl>
 	#include <southbridge/intel/i82801jx/acpi/globalnvs.asl>

src/soc/intel/baytrail/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name(\PICM, 0)		/* IOAPIC/8259 */
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	/* 0x00 - Operating System */
+	,	16,	/* 0x00 - Operating System */
 	SMIF,	 8,	/* 0x02 - SMI function */
 	PRM0,	 8,	/* 0x03 - SMI function parameter */
 	PRM1,	 8,	/* 0x04 - SMI function parameter */

src/soc/intel/baytrail/include/soc/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/soc/intel/braswell/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name(\PICM, 0)		/* IOAPIC/8259 */
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	/* 0x00 - Operating System */
+	,	16,	/* 0x00 - Operating System */
 	SMIF,	 8,	/* 0x02 - SMI function */
 	PRM0,	 8,	/* 0x03 - SMI function parameter */
 	PRM1,	 8,	/* 0x04 - SMI function parameter */

src/soc/intel/braswell/include/soc/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/soc/intel/broadwell/include/soc/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/soc/intel/broadwell/pch/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name (\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	8,	// 0x02 - SMI function
 	PRM0,	8,	// 0x03 - SMI function parameter
 	PRM1,	8,	// 0x04 - SMI function parameter

src/soc/intel/common/block/acpi/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name (\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	8,	// 0x02 - SMI function
 	,	8,	// 0x03 - Processor Count
 	PPCM,	8,	// 0x04 - Max PPC State

src/soc/intel/common/block/include/intelblocks/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - 0x01 Operating System */
+	u16	unused_was_osys; /* 0x00 - 0x01 Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	unused_was_pcnt; /* 0x03 - Processor Count */
 	u8	ppcm; /* 0x04 - Max PPC State */

src/soc/intel/denverton_ns/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name(\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	 8,	// 0x02 - SMI function
 	PRM0,	 8,	// 0x03 - SMI function parameter
 	PRM1,	 8,	// 0x04 - SMI function parameter

src/soc/intel/denverton_ns/include/soc/nvs.h

@@ -5,7 +5,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16 osys; /* 0x00 - Operating System */
+	u16 unused_was_osys; /* 0x00 - Operating System */
 	u8 smif;  /* 0x02 - SMI function call ("TRAP") */
 	u8 prm0;  /* 0x03 - SMI function call parameter */
 	u8 prm1;  /* 0x04 - SMI function call parameter */

src/soc/intel/skylake/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name (\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	8,	// 0x02 - SMI function
 	PRM0,	8,	// 0x03 - SMI function parameter
 	PRM1,	8,	// 0x04 - SMI function parameter

src/soc/intel/skylake/include/soc/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/southbridge/intel/bd82x6x/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name(\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	 8,	// 0x02 - SMI function
 	PRM0,	 8,	// 0x03 - SMI function parameter
 	PRM1,	 8,	// 0x04 - SMI function parameter

src/southbridge/intel/bd82x6x/include/soc/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/southbridge/intel/i82801gx/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name(\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	 8,	// 0x02 - SMI function
 	PRM0,	 8,	// 0x03 - SMI function parameter
 	PRM1,	 8,	// 0x04 - SMI function parameter

src/southbridge/intel/i82801gx/include/soc/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/southbridge/intel/i82801ix/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name(\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	 8,	// 0x02 - SMI function
 	PRM0,	 8,	// 0x03 - SMI function parameter
 	PRM1,	 8,	// 0x04 - SMI function parameter

src/southbridge/intel/i82801ix/include/soc/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/southbridge/intel/i82801jx/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name(\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	 8,	// 0x02 - SMI function
 	PRM0,	 8,	// 0x03 - SMI function parameter
 	PRM1,	 8,	// 0x04 - SMI function parameter

src/southbridge/intel/i82801jx/include/soc/nvs.h

@@ -6,7 +6,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/southbridge/intel/ibexpeak/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name(\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	 8,	// 0x02 - SMI function
 	PRM0,	 8,	// 0x03 - SMI function parameter
 	PRM1,	 8,	// 0x04 - SMI function parameter

src/southbridge/intel/ibexpeak/include/soc/nvs.h

@@ -8,7 +8,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */

src/southbridge/intel/lynxpoint/acpi/globalnvs.asl

@@ -7,7 +7,7 @@ Name (\PICM, 0)		// IOAPIC/8259
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */
-	OSYS,	16,	// 0x00 - Operating System
+	,	16,	// 0x00 - Operating System
 	SMIF,	 8,	// 0x02 - SMI function
 	PRM0,	 8,	// 0x03 - SMI function parameter
 	PRM1,	 8,	// 0x04 - SMI function parameter

src/southbridge/intel/lynxpoint/include/soc/nvs.h

@@ -7,7 +7,7 @@
 
 struct __packed global_nvs {
 	/* Miscellaneous */
-	u16	osys; /* 0x00 - Operating System */
+	u16	unused_was_osys; /* 0x00 - Operating System */
 	u8	smif; /* 0x02 - SMI function call ("TRAP") */
 	u8	prm0; /* 0x03 - SMI function call parameter */
 	u8	prm1; /* 0x04 - SMI function call parameter */