sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a capability for mainboard-specific posting.

Browse Source 
Some mainboards have really nice capabilities for posting, beyond
simple POST cards. Further, some can not use a POST card. This
change defines a weak symbol (mainboard_post) that can be overridden
by a real mainboard_post function.

If, for example, you'd like to do something fancy before the payload starts,
you can add this to mainboard.c:

void mainboard_post(u8 value)
{
	switch(value){
		case POST_TIME_TO_PARTY: some_fancy_lights();
		break;
	}
}

Maybe the post function should be an entry in the device. We're beginning to over-use
weak symbols.

BUG=None

TEST=Build and boot a google chromebook. Observe that it still works. Use it to drive
some pretty lights.

Change-Id: I3512d2ec34a66c747287191851c3f68b6a7cc1b2
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/1397
Tested-by: build bot (Jenkins)
This commit is contained in:
Alexandru Gagniuc
2012-08-03 13:20:57 -05:00
parent 16b022a15c
commit f88204e02b
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/console/post.c
View File

@@ -24,6 +24,20 @@
/* Write POST information */ /* Write POST information */
/* someday romcc will be gone. */
#ifndef __ROMCC__
/* Some mainboards have very nice features beyond just a simple display.
* They can override this function.
*/
void __attribute__((weak)) mainboard_post(uint8_t value)
{
}
#else
/* This just keeps the number of #ifs to a minimum */
#define mainboard_post(x)
#endif
void post_code(uint8_t value) void post_code(uint8_t value)
{ {
#if !CONFIG_NO_POST #if !CONFIG_NO_POST
@@ -34,4 +48,5 @@ void post_code(uint8_t value)
#endif #endif
outb(value, CONFIG_POST_PORT); outb(value, CONFIG_POST_PORT);
#endif #endif
mainboard_post(value);
} }

2
src/include/console/console.h
View File

@@ -69,6 +69,8 @@ extern int console_loglevel;
#ifndef __ROMCC__ #ifndef __ROMCC__
void console_init(void); void console_init(void);
void post_code(u8 value); void post_code(u8 value);
/* this function is weak and can be overridden by a mainboard function. */
void mainboard_post(u8 value);
void __attribute__ ((noreturn)) die(const char *msg); void __attribute__ ((noreturn)) die(const char *msg);
int do_printk(int msg_level, const char *fmt, ...) __attribute__((format(printf, 2, 3))); int do_printk(int msg_level, const char *fmt, ...) __attribute__((format(printf, 2, 3)));