sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/{common,picasso}: Move GFX device from static ASL to SSDT

Browse Source 
This change:
1. Adds PCI device for graphics controller in ACPI SSDT tables using
acpi_device_write_pci_dev().
2. Gets rid of IGFX device from picasso acpi/northbridge.asl.

This makes it easier to ensure that we don't accidentally
make the DSDT and SSDT entries inconsistent w.r.t. ACPI name and
scope.

BUG=b:153858769

Change-Id: I3a967cdc43b74f786e645d3fb666506070851a99
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40677
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Furquan Shaikh
2020-04-23 14:13:02 -07:00
parent 9e1a49cea5
commit f939df7a95
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/amd/common/block/graphics/graphics.c
View File

@@ -1,9 +1,16 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
/* This file is part of the coreboot project. */ /* This file is part of the coreboot project. */
#include <arch/acpi_device.h>
#include <device/pci.h> #include <device/pci.h>
#include <device/pci_ids.h> #include <device/pci_ids.h>
static void graphics_fill_ssdt(struct device *dev)
{
acpi_device_write_pci_dev(dev);
pci_rom_ssdt(dev);
}
static const char *graphics_acpi_name(const struct device *dev) static const char *graphics_acpi_name(const struct device *dev)
{ {
return "IGFX"; return "IGFX";
@@ -16,7 +23,7 @@ static const struct device_operations graphics_ops = {
.init = pci_dev_init, .init = pci_dev_init,
.ops_pci = &pci_dev_ops_pci, .ops_pci = &pci_dev_ops_pci,
.write_acpi_tables = pci_rom_write_acpi_tables, .write_acpi_tables = pci_rom_write_acpi_tables,
.acpi_fill_ssdt = pci_rom_ssdt, .acpi_fill_ssdt = graphics_fill_ssdt,
.acpi_name = graphics_acpi_name, .acpi_name = graphics_acpi_name,
}; };

5
src/soc/amd/picasso/acpi/northbridge.asl
View File

@@ -32,11 +32,6 @@ Device(AMRT) {
Name(_ADR, 0x00000000) Name(_ADR, 0x00000000)
} /* end AMRT */ } /* end AMRT */
/* Internal Graphics */
Device(IGFX) {
Name(_ADR, 0x00010000)
}
/* Gpp 0 */ /* Gpp 0 */
Device(PBR4) { Device(PBR4) {
Name(_ADR, 0x00020001) Name(_ADR, 0x00020001)