sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/data_fabric_helper: make some helper functions static

Browse Source 
data_fabric_disable_mmio_reg and data_fabric_find_unused_mmio_reg are
only used by data_fabric_set_mmio_np in the same file, so make them
static and drop the prototype from the header file.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6bf7a868aae2fd01b8adecd3e4cba6ff6d5119af
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77985
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Felix Held
2023-09-15 21:59:39 +02:00
parent cb2561d276
commit fbb612f6d2
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/data_fabric/data_fabric_helper.c
View File

@@ -71,7 +71,7 @@ void data_fabric_print_mmio_conf(void)
} }
} }
void data_fabric_disable_mmio_reg(unsigned int reg) static void data_fabric_disable_mmio_reg(unsigned int reg)
{ {
union df_mmio_control ctrl = { .dst_fabric_id = IOMS0_FABRIC_ID }; union df_mmio_control ctrl = { .dst_fabric_id = IOMS0_FABRIC_ID };
data_fabric_broadcast_write32(DF_MMIO_CONTROL(reg), ctrl.raw); data_fabric_broadcast_write32(DF_MMIO_CONTROL(reg), ctrl.raw);
@@ -86,7 +86,7 @@ static bool is_mmio_reg_disabled(unsigned int reg)
return !(ctrl.we || ctrl.re); return !(ctrl.we || ctrl.re);
} }
int data_fabric_find_unused_mmio_reg(void) static int data_fabric_find_unused_mmio_reg(void)
{ {
for (unsigned int i = 0; i < DF_MMIO_REG_SET_COUNT; i++) { for (unsigned int i = 0; i < DF_MMIO_REG_SET_COUNT; i++) {
if (is_mmio_reg_disabled(i)) if (is_mmio_reg_disabled(i))

2
src/soc/amd/common/block/include/amdblocks/data_fabric.h
View File

@@ -47,8 +47,6 @@ void data_fabric_broadcast_write32(uint16_t fn_reg, uint32_t data)
} }
void data_fabric_print_mmio_conf(void); void data_fabric_print_mmio_conf(void);
void data_fabric_disable_mmio_reg(unsigned int reg);
int data_fabric_find_unused_mmio_reg(void);
void data_fabric_set_mmio_np(void); void data_fabric_set_mmio_np(void);
enum cb_err data_fabric_get_pci_bus_numbers(struct device *domain, uint8_t *first_bus, enum cb_err data_fabric_get_pci_bus_numbers(struct device *domain, uint8_t *first_bus,