From fbd13a84cf0d02a42188c00cf68f40b2b00af9d0 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Sat, 31 Dec 2022 16:40:58 -0700 Subject: [PATCH] vc/google: Add and use POST_CODE_CLEAR definition The CR50 code clears the post code value. Add this as a #define. Signed-off-by: Martin Roth Change-Id: If3b73a3159ac8ac9ab08c6ff705b0ca289ab453c Reviewed-on: https://review.coreboot.org/c/coreboot/+/71592 Tested-by: build bot (Jenkins) Reviewed-by: Jon Murphy Reviewed-by: Eric Lai --- src/commonlib/include/commonlib/console/post_codes.h | 6 ++++++ src/vendorcode/google/chromeos/cr50_enable_update.c | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/commonlib/include/commonlib/console/post_codes.h b/src/commonlib/include/commonlib/console/post_codes.h index d838815fa2..ef296bda49 100644 --- a/src/commonlib/include/commonlib/console/post_codes.h +++ b/src/commonlib/include/commonlib/console/post_codes.h @@ -27,6 +27,12 @@ #ifndef POST_CODES_H #define POST_CODES_H +/** + * \brief Not an actual post-code - used to clear port80h + * + */ +#define POST_CODE_CLEAR 0x00 + /** * \brief Entry into 'crt0.s'. reset code jumps to here * diff --git a/src/vendorcode/google/chromeos/cr50_enable_update.c b/src/vendorcode/google/chromeos/cr50_enable_update.c index 9ac33a52b4..6beea913ca 100644 --- a/src/vendorcode/google/chromeos/cr50_enable_update.c +++ b/src/vendorcode/google/chromeos/cr50_enable_update.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include +#include #include #include #include @@ -133,7 +134,7 @@ static void enable_update(void *unused) mainboard_prepare_cr50_reset(); /* clear current post code avoid chatty eventlog on subsequent boot*/ - post_code(0); + post_code(POST_CODE_CLEAR); /* * Older Cr50 firmware doesn't support the timeout parameter for the