From fd63492205dfb22fdcad663f6b1c6a589ac4b035 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Mon, 31 Jul 2023 09:59:07 -0600 Subject: [PATCH] util/genbuild: Correctly remove IASL warning If IASL isn't installed, the genbuild script throws a confusing warning. This can and should be ignored because toolchain.inc will find this and provide a much better error message. The trailing >/dev/null was probably intended to do this, but didn't actually affect anything. Adding quotes around the IASL command will make "" be the command that tries to get run instead of `-v` when IASL isn't present. This will always be a failure, whereas `-v` could theoretically be a valid command. Signed-off-by: Martin Roth Change-Id: Ibff93db670766c4de21faa7553f2003450465407 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76857 Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer --- util/genbuild_h/genbuild_h.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh index 5e2fe7df8f..2bfcc4c3b6 100755 --- a/util/genbuild_h/genbuild_h.sh +++ b/util/genbuild_h/genbuild_h.sh @@ -70,7 +70,7 @@ eval "$(grep ^IASL:= "${XCOMPILE}" 2>/dev/null | sed s,:=,=,)" if [ ! -x "${IASL}" ]; then IASL=$(command -v iasl) fi -IASLVERSION="$(${IASL} -v | grep version | sed 's/.*version //')" >/dev/null +IASLVERSION="$("${IASL}" -v 2>/dev/null | grep version | sed 's/.*version //')" #Print out the information that goes into build.h printf "/* build system definitions (autogenerated) */\n"