diff --git a/src/mainboard/system76/galp5/romstage.c b/src/mainboard/system76/galp5/romstage.c index d68c6d4ad4..c05a507e00 100644 --- a/src/mainboard/system76/galp5/romstage.c +++ b/src/mainboard/system76/galp5/romstage.c @@ -8,8 +8,10 @@ static const struct mb_ddr4_cfg board_cfg = { // dq_map unused on DDR4 // dqs_map unused on DDR4 + // TGL-U does not support interleaved memory .dq_pins_interleaved = 0, + //TODO: can we use early command training? .ect = 0, }; @@ -31,6 +33,5 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) { //TODO: what is this for? const bool half_populated = false; - meminit_ddr4(&mupd->FspmConfig, &board_cfg, &spd, half_populated); } diff --git a/src/mainboard/system76/lemp10/romstage.c b/src/mainboard/system76/lemp10/romstage.c index 1866527ba7..d99884da47 100644 --- a/src/mainboard/system76/lemp10/romstage.c +++ b/src/mainboard/system76/lemp10/romstage.c @@ -26,6 +26,9 @@ static const struct spd_info spd = { }; void mainboard_memory_init_params(FSPM_UPD *mupd) { + //TODO: Allow memory clocks higher than 2933 MHz + mupd->FspmConfig.SaOcSupport = 1; + //TODO: what is this for? const bool half_populated = false; meminit_ddr4(&mupd->FspmConfig, &board_cfg, &spd, half_populated);