sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use convenience function to checksum

Browse Source 
That coreboot uses the IP checksum is an artifact, not a deliberate
requirement to be compatible with the Internet Protocole suite. Use
a wrapper to abstract the computation of coreboot's checksum.

Change-Id: I6491b9ba5efb9ffe5cb12a6172653a6ac80a1370
Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
Reviewed-on: http://review.coreboot.org/497
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Philip Prindeville 2011-12-23 17:22:05 -07:00 committed by Patrick Georgi
parent 46404d75e4
commit fe2f6b075e
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
payloads/coreinfo/coreboot_module.c
View File

@ -17,8 +17,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#include <coreboot_tables.h>
#include "coreinfo.h" #include "coreinfo.h"
#include <coreboot_tables.h>
#ifdef CONFIG_MODULE_COREBOOT #ifdef CONFIG_MODULE_COREBOOT
@ -189,10 +189,10 @@ static int parse_header(void *addr, int len)
/* FIXME: Check the checksum. */ /* FIXME: Check the checksum. */
if (ipchksum((uint16_t *) header, sizeof(*header))) if (cb_checksum(header, sizeof(*header)))
return -1; return -1;
if (ipchksum((uint16_t *) (ptr + sizeof(*header)), header->table_bytes) if (cb_checksum((ptr + sizeof(*header)), header->table_bytes)
!= header->table_checksum) != header->table_checksum)
return -1; return -1;

5
payloads/libpayload/include/coreboot_tables.h
View File

@ -223,6 +223,11 @@ static inline u64 cb_unpack64(struct cbuint64 val)
return (((u64) val.hi) << 32) | val.lo; return (((u64) val.hi) << 32) | val.lo;
} }
static inline u16 cb_checksum(const void *ptr, unsigned len)
{
return ipchksum(ptr, len);
}
/* Helpful macros */ /* Helpful macros */
#define MEM_RANGE_COUNT(_rec) \ #define MEM_RANGE_COUNT(_rec) \