From fe3b3e05da8a96cf16fbb71962fa4d99ccc3bd90 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 8 May 2023 19:30:59 +0200 Subject: [PATCH] mb/google/mistral: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I1033a974a818308b31e1334cad5869d2cd81bd9e Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/75017 Reviewed-by: Martin L Roth Tested-by: build bot (Jenkins) --- src/mainboard/google/mistral/Kconfig | 3 +++ src/mainboard/google/mistral/Kconfig.name | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/mistral/Kconfig b/src/mainboard/google/mistral/Kconfig index 0703cbd1a9..9bd8af27e7 100644 --- a/src/mainboard/google/mistral/Kconfig +++ b/src/mainboard/google/mistral/Kconfig @@ -2,6 +2,9 @@ config BOARD_GOOGLE_MISTRAL_COMMON # Umbrella option to be selected by variants def_bool n +config BOARD_GOOGLE_MISTRAL + select BOARD_GOOGLE_MISTRAL_COMMON + if BOARD_GOOGLE_MISTRAL_COMMON config BOARD_SPECIFIC_OPTIONS diff --git a/src/mainboard/google/mistral/Kconfig.name b/src/mainboard/google/mistral/Kconfig.name index 2d0783e1ea..6e9582705a 100644 --- a/src/mainboard/google/mistral/Kconfig.name +++ b/src/mainboard/google/mistral/Kconfig.name @@ -2,4 +2,3 @@ comment "Mistral" config BOARD_GOOGLE_MISTRAL bool "-> Mistral" - select BOARD_GOOGLE_MISTRAL_COMMON