sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/smm_module_loader.c: Clean up printing the CPU map

Browse Source 
There is no reason to do this in a separate loop.

Change-Id: I7fe9f1004597602147aae72f4b754395b6b527cf
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63473
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Arthur Heymans
2022-04-07 18:33:50 +02:00
parent bc749a068a
commit ff69b6f4d5
1 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/cpu/x86/smm/smm_module_loader.c
View File

@@ -126,38 +126,26 @@ static int smm_create_map(uintptr_t smbase, unsigned int num_cpus,
} }
for (i = 0; i < num_cpus; i++) { for (i = 0; i < num_cpus; i++) {
printk(BIOS_DEBUG, "CPU 0x%x\n", i);
cpus[i].smbase = base; cpus[i].smbase = base;
cpus[i].entry = base + smm_entry_offset; cpus[i].entry = base + smm_entry_offset;
printk(BIOS_DEBUG, " smbase %lx entry %lx\n", cpus[i].smbase,
cpus[i].entry);
cpus[i].ss_start = cpus[i].entry + (smm_entry_offset - ss_size); cpus[i].ss_start = cpus[i].entry + (smm_entry_offset - ss_size);
cpus[i].code_start = cpus[i].entry; cpus[i].code_start = cpus[i].entry;
cpus[i].code_end = cpus[i].entry + stub_size; cpus[i].code_end = cpus[i].entry + stub_size;
printk(BIOS_DEBUG, " ss_start %lx code_end %lx\n", cpus[i].ss_start,
cpus[i].code_end);
cpus[i].active = 1; cpus[i].active = 1;
base -= ss_size; base -= ss_size;
seg_count++; seg_count++;
if (seg_count >= cpus_in_segment) { if (seg_count >= cpus_in_segment) {
base -= smm_entry_offset; base -= smm_entry_offset;
seg_count = 0; seg_count = 0;
printk(BIOS_DEBUG, "-------------NEW CODE SEGMENT --------------\n");
} }
} }
if (CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG) {
seg_count = 0;
for (i = 0; i < num_cpus; i++) {
printk(BIOS_DEBUG, "CPU 0x%x\n", i);
printk(BIOS_DEBUG,
" smbase %lx entry %lx\n",
cpus[i].smbase, cpus[i].entry);
printk(BIOS_DEBUG,
" ss_start %lx code_end %lx\n",
cpus[i].ss_start, cpus[i].code_end);
seg_count++;
if (seg_count >= cpus_in_segment) {
printk(BIOS_DEBUG,
"-------------NEW CODE SEGMENT --------------\n");
seg_count = 0;
}
}
}
return 1; return 1;
} }