sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb,soc/amd: Drop OSFL method in ASL

Browse Source 
Variable OSVR had a static value of 3 and OSFL() did not
actually call _OSI or _OS methods.

The conditional in HDA _INI method of OSVR is dropped and
use of DMA NoSnoop attribute remains disabled to retain
previous behaviour. For soc/amd/picasso a different decision
was made in CB:40782 as HDA _INI method was just dropped and
default configuration enables use of DMA NoSnoop attribute.

Change-Id: I967b7b2afbb43253cccb4b77f6c44db45e2989e4
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50592
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki
2021-02-09 17:38:23 +02:00
parent b484609a02
commit ff9ba54ce1
25 changed files with 9 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/southbridge/amd/agesa/hudson/acpi/audio.asl
View File

@@ -28,11 +28,8 @@ Device(AZHD) { /* 0:14.2 - HD Audio */
Method (_INI, 0, NotSerialized)
{
If (OSVR == 0x03)
{
NSEN = 0
NSDO = 1
NSDI = 1
}
NSEN = 0
NSDO = 1
NSDI = 1
}
} /* end AZHD */

24
src/southbridge/amd/agesa/hudson/acpi/fch.asl
View File

@@ -158,33 +158,9 @@ Method(_INI, 0) {
/* DBGO(\_REV) */
/* DBGO("\n") */
/* Determine the OS we're running on */
OSFL()
#if CONFIG(HUDSON_IMC_FWM)
#if CONFIG(ACPI_ENABLE_THERMAL_ZONE)
ITZE() /* enable IMC Fan Control*/
#endif
#endif
} /* End Method(_SB._INI) */
Method(OSFL, 0){
if (OSVR != Ones) {Return (OSVR)} /* OS version was already detected */
if (CondRefOf(\_OSI))
{
OSVR = 1 /* Assume some form of XP */
if (\_OSI("Windows 2006")) /* Vista */
{
OSVR = 2
}
} else {
If (WCMP(\_OS,"Linux")) {
OSVR = 3 /* Linux */
} Else {
OSVR = 4 /* Gotta be WinCE */
}
}
Return (OSVR)
}

9
src/southbridge/amd/pi/hudson/acpi/audio.asl
View File

@@ -28,11 +28,8 @@ Device(AZHD) { /* 0:14.2 - HD Audio */
Method (_INI, 0, NotSerialized)
{
If (OSVR == 0x03)
{
NSEN = 0
NSDO = 1
NSDI = 1
}
NSEN = 0
NSDO = 1
NSDI = 1
}
} /* end AZHD */

24
src/southbridge/amd/pi/hudson/acpi/fch.asl
View File

@@ -144,33 +144,9 @@ Method(_INI, 0) {
/* DBGO(\_REV) */
/* DBGO("\n") */
/* Determine the OS we're running on */
OSFL()
#if CONFIG(HUDSON_IMC_FWM)
#if CONFIG(ACPI_ENABLE_THERMAL_ZONE)
ITZE() /* enable IMC Fan Control*/
#endif
#endif
} /* End Method(_SB._INI) */
Method(OSFL, 0){
if (OSVR != Ones) {Return (OSVR)} /* OS version was already detected */
if (CondRefOf(\_OSI))
{
OSVR = 1 /* Assume some form of XP */
if (\_OSI("Windows 2006")) /* Vista */
{
OSVR = 2
}
} else {
If (WCMP(\_OS,"Linux")) {
OSVR = 3 /* Linux */
} Else {
OSVR = 4 /* Gotta be WinCE */
}
}
Return (OSVR)
}