Martin Roth
6dac0c54cd
util/lint: Update to check all of src for license headers
...
This wasn't done previously because not all files in the
src directory had the correct headers. Doing this earlier
would have broken the build.
Signed-off-by: Martin Roth <martin.roth@amd.corp-partner.google.com >
Change-Id: Ia6d7a7a17116e4c8e55354783085355fd45ff87a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66505
Reviewed-by: Paul Menzel <paulepanter@mailbox.org >
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com >
2022-08-17 19:43:30 +00:00
Martin Roth
251e26683e
util/lint: Add .gitignore files to list that don't need a license
...
Signed-off-by: Martin Roth <martin.roth@amd.corp-partner.google.com >
Change-Id: I568a357b40e8bb69b2b26752d241f06adfbe029e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66503
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com >
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com >
2022-08-11 17:53:48 +00:00
Martin Roth
f67a1aa76a
util/lint & LICENSES: Add PDDC as a "license" for coreboot
...
The Creative Commons Public Domain Dedication and Certification is not
a license in the common sense in that it's stating that the associated
file is already in the public domain (having no copyright), and is not
actually putting it in the public domain like the CC-C0 license does.
The use for this in coreboot is for unlicensable files - either blank
files or files with no creative content. This allows these files to
have the SPDX identifier to identify them as having no known copyright
for open source license compliance.
If CC-PDM-1.0 is ever included in the list of SPDX licenses, that would
probably fit better, but because the public domain mark isn't actually
a license, and because "public domain" isn't well defined, CC-PDM was
rejected as a SPDX identifier.
For further information:
https://web.archive.org/web/20201018194411/https://github.com/spdx/license-list-XML/issues/988
Change-Id: Ibb300ecd066cde2a016195c2beca76a460c588e3
Signed-off-by: Martin Roth <martin.roth@amd.corp-partner.google.com >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66496
Reviewed-by: Elyes Haouas <ehaouas@noos.fr >
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de >
2022-08-10 19:07:20 +00:00
Martin Roth
afa3e5aa49
util/lint & LICENSES: Add GCC-exception-3.1 to license exceptions
...
The gcov files in the lib directory are licensed GPL 3.0 with the GCC
runtime library exception.
Add this as a valid license so that the files can get a correct SPDX
identifier.
Signed-off-by: Martin Roth <martin.roth@amd.corp-partner.google.com >
Change-Id: I1cf9c3125592741923c9b4481038055f24fe6ab1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66495
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Paul Menzel <paulepanter@mailbox.org >
Reviewed-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de >
2022-08-10 19:07:02 +00:00
Elyes Haouas
50eef6566b
lint/checkpatch: Add check for used comma where semicolon could be
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I6d3a49378008bad61b2a18bd8cb28be952a18006
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65837
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:48:35 +00:00
Elyes Haouas
f9a3554a4a
lint/checkpatch: Add a check for use of self-assignments
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: If47a7826ee67a2be25a4caa2a447484e5f11411b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65836
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:48:24 +00:00
Elyes Haouas
e83e090b05
lint/checkpatch: Add a check for existence of a commit log
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I4e3b98140d900c5717f4badde71c7be88fd1e23a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65835
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:48:13 +00:00
Elyes Haouas
6e84c2ca70
lint/checkpatch: Update 'Check patch "separator" and "signoff"'
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: Id3d7375216af5bf75ed7ce61fa8ea2dfebe8ac77
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65834
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:47:59 +00:00
Elyes Haouas
cb346842ad
lint/checkpatch: Update 'check for unwanted Gerrit info'
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I856bfa0f0d39fda549671b1029cccdc39f831bab
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65833
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:47:49 +00:00
Elyes Haouas
e235a0de18
lint/checkpatch: Update 'uncoalesced string fragments'
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I21b2a0d87cbf610fc48e273ed78ab779ad4a6932
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65832
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:47:34 +00:00
Elyes Haouas
71bfcf528d
lint/checkpatch: Update 'concatenated string without spaces between elements'
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I04e58aca4a30e82f3da0cda08403d0daf3b5fb10
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65831
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:47:17 +00:00
Elyes Haouas
a59a87ca17
lint/checkpatch: Update 'check indentation of a line with a break'
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I79170a45cd8184ebc816b4f16656a3cfdc257f60
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65828
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:46:40 +00:00
Elyes Haouas
d92fcf448f
lint/checkpatch: Update 'check for logical continuations'
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I222e3378ded4cd73d0141cd1e38ac3282d311cc4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65827
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:46:22 +00:00
Elyes Haouas
86e4a3ae05
lint/checkpatch: Update 'check for adding lines without a newline'
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I1bd68e9a6609a3dfa7dc856f24e4b616714d9990
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65826
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:46:09 +00:00
Elyes Haouas
c5ede53ba8
lint/checkpatch: Update 'check for assignments on the start of a line'
...
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: Ia7d4b0176bad849e79f037f74c3d99ce9eb061c0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65825
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-07-19 01:45:55 +00:00
Martin Roth
93333cb34e
util/lint: Add coreboot specific dictionary file
...
This is a wordlist that I've compiled to use in spellcheckers to ignore
all of the coreboot specific terms.
Signed-off-by: Martin Roth <gaumless@gmail.com >
Change-Id: I718519000eaf31786380474eb71b99ca442e3bed
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64809
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-by: Felix Singer <felixsinger@posteo.net >
2022-06-22 21:40:19 +00:00
Elyes Haouas
709fdb1995
util/lint/checkpatch: Add alloc functions to alloc with multiplies check
...
This reduce difference with linux v5.18.
Change-Id: Id9412f7b6c0b9f76b39a094142aaded5c2aa1059
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64740
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-05-29 14:55:38 +00:00
Elyes Haouas
069dfe33a3
util/lint/checkpatch: Update 'Check for compiler attributes'
...
This reduce difference with linux v5.18.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I817630321587dec515cd94aa7b73a17819526190
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64604
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-05-29 14:55:21 +00:00
Elyes Haouas
a7b0d38964
util/lint/checkpatch.pl: Use 'allocFunctions'
...
This reduce difference with linux v5.18.
Change-Id: I1fc71b9cb6a4e4f8b27fbe6d45f4fa4e2c236157
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64603
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-05-29 14:55:02 +00:00
Martin Roth
97e7eea976
util/lint/checkpatch: Warn on period at the end of commit subject
...
This gives a warning when there's a period at the end of the commit
subject line.
Change-Id: If95bef3ba01e0ac13ce18045928081040abef4fd
Signed-off-by: Martin Roth <martin@coreboot.org >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63032
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-by: Paul Menzel <paulepanter@mailbox.org >
2022-05-28 01:26:03 +00:00
Martin Roth
341a53d1c5
util/lint: Subtract the patch format string from subject length
...
Checkpatch was looking for a 65 character length, but format-patch adds
the text "Subject: [PATCH] " before the actual subject. Checkpatch
needs to account for that when looking at the line length.
Lines 2863 & 2864 have their indentation fixed as well.
Signed-off-by: Martin Roth <gaumless@gmail.com >
Change-Id: I2f2ee6e0f1b14ae6393ed7e64ba1266aa9debc7d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64656
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Elyes Haouas <ehaouas@noos.fr >
2022-05-28 01:25:48 +00:00
Martin Roth
9e33723d9b
util/lint: Add commit message parsing to checkpatch_json script
...
The commit message wasn't being parsed because there's no filename
associated with it in the patch output. This change adds the "filename"
for the commit message in Gerrit for any errors that have a line number
but no filename.
calculations is intentionally misspelled as cacluations as a test.
Change-Id: Ie7a2ef06419c7090c8e44b3b734b1edf966597cc
Signed-off-by: Martin Roth <martin@coreboot.org >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63031
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Elyes Haouas <ehaouas@noos.fr >
2022-05-28 01:25:37 +00:00
Elyes Haouas
26e0b94614
util/lint/checkpatch.pl: Reduce difference with linux v5.18
...
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: Id5eb4823399088746a34721a9855bbaf5f97b7b6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64572
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-05-24 12:57:48 +00:00
Maximilian Brune
94223c4165
Allow trailing whitespaces in .md files
...
Two trailing whitesspaces have an actual meaning in Markdown files (a new line).
Signed-off-by: Maximilian Brune <maximilian.brune@9elements.com >
Change-Id: Ibdb92ee857ee4ad32b6afb84ace427b27b41bb7c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64032
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-05-16 19:58:31 +00:00
Martin Roth
af06e9adea
util/lint/lint-stable-019: Update grep '\s' to [[:blank:]]
...
For some reason, the '\s' syntax is causing an error for me under
freebsd. It's entirely possible that I'm doing something wrong, but
this change should be fine regardless.
Freebsd's grep, GNU grep, and git grep all handle posix regex classes,
so this change should be transparent.
Signed-off-by: Martin Roth <gaumless@gmail.com >
Change-Id: I489ec13b4ea2e9c17692888e42b8741763b1a2c5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63532
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Felix Singer <felixsinger@posteo.net >
2022-05-16 05:18:09 +00:00
Elyes Haouas
14c49e3646
util/lint/checkpatch.pl: Fix "uninitialized value" error message
...
Change-Id: I74807f240779060158c6769f63a6e9438a6e5fbe
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64173
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-05-16 02:28:44 +00:00
Elyes Haouas
0014bce46b
util/lint/checkpatch.pl: Fix "Invalid color mode" error message
...
Remove duplicated code:
"if ($color =~ /^[01]$/) {
$color = !$color;
} elsif ($color =~ /^always$/i) {
$color = 1;
} elsif ($color =~ /^never$/i) {
$color = 0;
} elsif ($color =~ /^auto$/i) {
$color = (-t STDOUT);
} else {
die "$P: Invalid color mode: $color\n";
}"
Change-Id: I5713c364edea806e58df26c3a37b4bba7603ed0a
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64172
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <gaumless@tutanota.com >
2022-05-16 02:28:02 +00:00
Elyes Haouas
43529c8b20
util/lint/checkpatch.pl: Update lines related to CONST_STRUCT
...
Update to v5.18-2 version.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I0fe2ec6a74a4b8c70452fbf05d534a37e1ea2c26
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63582
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:19:40 +00:00
Elyes Haouas
f0e150c35a
util/lint/checkpatch.pl: Add strlcpy check
...
Update to v5.18-2
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: Ic4eaa3f26bcd60ea509a52d5715c7ce1f43b6d3d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63581
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:18:55 +00:00
Elyes Haouas
8f59960fb2
util/lint/checkpatch.pl: Update C99_COMMENT_TOLERANCE lines
...
Update to v5.18-2 version.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: If230fa5cd01ab3ce91d8c910667c3d609cf978b0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63580
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:18:11 +00:00
Elyes Haouas
00d8ffdada
util/lint/checkpatch.pl: Update TYPECAST_INT_CONSTANT lines
...
Update to v5.18-2 version.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I8ed89e53f647b1b071abff33a434fb3b8dbb1de1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63579
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:17:34 +00:00
Elyes Haouas
84083a27aa
util/lint/checkpatch.pl: Update the check of repeated words
...
Update to v5.18-2 version.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I7f5e597bb76e1b9feeb2d6ea290626f45e9fe6c0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63577
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:17:00 +00:00
Elyes Haouas
f62a98939d
lint/checkpatch.pl: Update to v5.18-2 lines related to "CONFIG_"
...
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I8589d053871ad9ac64ae2f8fc380710be8e4556b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63576
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:16:14 +00:00
Elyes Haouas
0b1a03cd18
util/lint/checkpatch.pl: Update lines related to max_line_length
...
Upadate to v5.18-2 version.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: Ib9927bfa98e20d4b621bf7abecec234b4754ee9c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63439
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:16:04 +00:00
Elyes Haouas
41d43f5eeb
util/lint/checkpatch.pl: Update lines related to tabsize
...
Update to v5.18-2 version.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I6651a3f8e79beca2e1235fe8de3217875f81ba2b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63438
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:15:33 +00:00
Elyes Haouas
46b07e53f5
util/lint/checkpatch.pl: Update to v5.18-2 lines related to verbosity
...
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Change-Id: I66f38cb01e58ee241bf58c4db83693029ddebcfa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63437
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin L Roth <martinroth@google.com >
2022-04-24 21:14:24 +00:00
Elyes Haouas
84ef4fb15b
util/lint/checkpatch.pl: Update to v5.18-2 lines related to "codespell"
...
Change-Id: I55cc4255ea88723c813a04d87e4c028c64f92dbd
Signed-off-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63435
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2022-04-11 13:59:59 +00:00
Martin Roth
10d34b7818
util/lint/checkpatch: Update commit message & subject line limits
...
The commit message has a (soft) line length limit of 72 characters and
the subject has a (soft) line limit of 65 characters. This change
updates checkpatch to warn at those limits.
Note that neither of these are hard limits because git & gerrit can both
handle longer lines, it just doesn't look good.
Change-Id: I4ef131a65254e2b184b05e0215969aef97e12712
Signed-off-by: Martin Roth <martin@coreboot.org >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63029
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Paul Menzel <paulepanter@mailbox.org >
Reviewed-by: Elyes Haouas <ehaouas@noos.fr >
Reviewed-by: Felix Singer <felixsinger@posteo.net >
2022-03-25 19:23:59 +00:00
Elyes HAOUAS
f2a9c8d57c
util/lint/checkpatch.pl: Use "git_command"
...
This is to reduce difference with linux v5.16.
Change-Id: I7abd4d8eed856eee841422515db2ff7f50ecd0a4
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61471
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2022-02-01 17:34:28 +00:00
Elyes HAOUAS
18ef52083d
util/lint/checkpatch.pl: Use "gitroot"
...
This is to reduce difference with linux v5.16.
Change-Id: I3bdf880c8b6068467665865b7cf1249d1047e833
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61470
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2022-01-31 17:46:49 +00:00
Elyes HAOUAS
249c4044c2
util/lint/checkpatch: Update "check for missing blank lines after declarations"
...
This is to reduce difference with linux v5.16.
Change-Id: I1b7bc2b4ec832f0abeda215c381856a5ec153883
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61469
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2022-01-31 17:46:40 +00:00
Elyes HAOUAS
ac69049030
util/lint/checkpatch.pl: Update 'commit message line length limit'
...
Also add "coreboot" comment on our modification.
Change-Id: Ida58a92457e25bac7fb89bb5882e7647f388ec01
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61468
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2022-01-31 17:46:31 +00:00
Elyes HAOUAS
919b0c7d4d
util/lint/checkpatch.pl: Remove unneeded whitespaces and fix some typos
...
This is to reduce difference with linux v5.16.
Change-Id: I4aa7abce83b41ccd5129717cd3bf85be19ec4807
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61467
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2022-01-31 17:46:22 +00:00
Elyes HAOUAS
48cb78b6d9
util/lint/checkpatch.pl: Use "perl_version_ok"
...
Also use '$minimum_perl_version'.
This is to reduce difference with linux v5.16.
Change-Id: I7c2f5d5c9853dc8ddc8f89a5e2edd6c8613ba790
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61466
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2022-01-31 17:46:13 +00:00
Elyes HAOUAS
96771bf92c
util/lint/checkpatch.pl: Use "tabsize"
...
This is to reduce difference with linux v5.16.
Change-Id: Ifeb9c4406737fa24f9bd803af48d8b8d17654940
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60874
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2022-01-31 17:45:44 +00:00
Martin Roth
38c7314137
util/lint: Remove SuperIO from checkpatch spellcheck
...
Patch 423e9e0fc0gaumless@gmail.com >
Change-Id: I464305af539926ac8a45c9c0d59eeb2c78dea17a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61434
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Paul Menzel <paulepanter@mailbox.org >
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr >
2022-01-31 03:34:30 +00:00
Fred Reitberger
bfdc132436
util/lint/lint-stable-003-whitespace: add exception for gif files
...
Adding gif files to the whitespace exclude list, to prevent issue where
commits were failing due to binary files.
Change-Id: I56679780348579d01c81c6f1677e4ea456315c9e
Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61460
Reviewed-by: Felix Held <felix-coreboot@felixheld.de >
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com >
Reviewed-by: Paul Menzel <paulepanter@mailbox.org >
Reviewed-by: Nico Huber <nico.h@gmx.de >
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
2022-01-28 20:36:38 +00:00
Paul Menzel
dd1ee27503
util/lint/checkpatch: Decrease commit message line length limit to 72
...
Currently, `checkpatch.pl`, imported from the Linux project, checks for
75 characters per line [2]:
> Suggest line wrapping at 75 columns so the default git commit log
> indentation of 4 plus the commit message text still fits on an 80
> column screen.
But Gerrit’s Web interface and its commit hooks use with 72 characters
per line [2]:
remote: commit 35bb56d: warning: too many message lines longer than 72 characters; manually wrap lines
remote:
remote: SUCCESS
remote:
remote: https://review.coreboot.org/c/coreboot/+/60004 [DO NOT SUBMIT] Gerrit commit msg line length test [NEW]
So, decrease the suggested length from 75 to 72 characters per line.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2a076f40d8c9be95bee7bcf18436655e1140447f
[2]: https://review.coreboot.org/60004
Change-Id: Ic9c686cb1a902259b18377b76b5c999e94660fed
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60006
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2021-12-10 20:54:56 +00:00
Patrick Georgi
423e9e0fc0
Documentation/lint: Use Super I/O instead of SuperIO
...
Change-Id: Idb16092b687ebffb319bc1908f08f350d612d36a
Signed-off-by: Patrick Georgi <pgeorgi@google.com >
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39451
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Paul Menzel <paulepanter@mailbox.org >
Reviewed-by: Martin Roth <martinroth@google.com >
2021-11-19 14:47:20 +00:00
Sean Rhodes
c9bc7a7591
util/lint: Fix linters to work with coreboot-configurator
...
* Exclude .gif files from newline checking
* Exclude coreboot-configurator from checkpatch checking
Signed-off-by: Sean Rhodes <sean@starlabs.systems >
Change-Id: I1b07b7b05340409e5c1695cc7bbdea68f8190097
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59096
Tested-by: build bot (Jenkins) <no-reply@coreboot.org >
Reviewed-by: Patrick Georgi <patrick@coreboot.org >
2021-11-19 13:34:55 +00:00
