079b5c65c3
We found that sometimes the edp doesn't get the edid or that video config fails on kevin after a reboot. Now we will retry 3 times to initialize it if there are errors. BRANCH=gru BUG=chrome-os-partner:60150 TEST=reboot kevin, the edp initialization error is no longer seen. Change-Id: I96e20e526294fbc856fbdffcbd63accdc7371ef6 Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Original-Commit-Id: 28c57a6e5b89c7b3a96204ec19a080067460544a Original-Change-Id: I1382cdf4119fc4eeae5c2b36485030e3a38c2d91 Original-Signed-off-by: Lin Huang <hl@rock-chips.com> Original-Reviewed-on: https://chromium-review.googlesource.com/412622 Original-Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/17626 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth@google.com>
124 lines
3.0 KiB
C
124 lines
3.0 KiB
C
/*
|
|
* This file is part of the coreboot project.
|
|
*
|
|
* Copyright 2016 Rockchip Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <arch/cache.h>
|
|
#include <arch/mmu.h>
|
|
#include <arch/io.h>
|
|
#include <console/console.h>
|
|
#include <device/device.h>
|
|
#include <delay.h>
|
|
#include <edid.h>
|
|
#include <gpio.h>
|
|
#include <stdlib.h>
|
|
#include <stddef.h>
|
|
#include <string.h>
|
|
#include <soc/addressmap.h>
|
|
#include <soc/clock.h>
|
|
#include <soc/display.h>
|
|
#include <soc/edp.h>
|
|
#include <soc/gpio.h>
|
|
#include <soc/grf.h>
|
|
#include <soc/mmu_operations.h>
|
|
#include <soc/soc.h>
|
|
#include <soc/vop.h>
|
|
|
|
#include "chip.h"
|
|
|
|
void rk_display_init(device_t dev)
|
|
{
|
|
struct edid edid;
|
|
struct soc_rockchip_rk3399_config *conf = dev->chip_info;
|
|
enum vop_modes detected_mode = VOP_MODE_UNKNOWN;
|
|
int retry_count = 0;
|
|
|
|
/* let's use vop0 in rk3399 */
|
|
uint32_t vop_id = 0;
|
|
|
|
switch (conf->vop_mode) {
|
|
case VOP_MODE_NONE:
|
|
return;
|
|
case VOP_MODE_AUTO_DETECT:
|
|
/* try EDP first, then HDMI */
|
|
case VOP_MODE_EDP:
|
|
printk(BIOS_DEBUG, "Attempting to set up EDP display.\n");
|
|
rkclk_configure_vop_aclk(vop_id, 200 * MHz);
|
|
|
|
/* select edp signal from vop0 */
|
|
write32(&rk3399_grf->soc_con20, RK_CLRBITS(1 << 5));
|
|
|
|
/* select edp clk from SoC internal 24M crystal, otherwise,
|
|
* it will source from edp's 24M clock (that depends on
|
|
* edp vendor, could be unstable)
|
|
*/
|
|
write32(&rk3399_grf->soc_con25, RK_SETBITS(1 << 11));
|
|
|
|
retry_edp:
|
|
rk_edp_init();
|
|
if (rk_edp_get_edid(&edid) == 0) {
|
|
detected_mode = VOP_MODE_EDP;
|
|
break;
|
|
}
|
|
goto edp_error;
|
|
|
|
/* fall thru */
|
|
case VOP_MODE_HDMI:
|
|
printk(BIOS_WARNING, "HDMI display is NOT supported yet.\n");
|
|
return;
|
|
default:
|
|
printk(BIOS_WARNING, "Cannot read any EDID info, aborting.\n");
|
|
return;
|
|
}
|
|
|
|
if (rkclk_configure_vop_dclk(vop_id,
|
|
edid.mode.pixel_clock * KHz)) {
|
|
printk(BIOS_WARNING, "config vop err\n");
|
|
return;
|
|
}
|
|
|
|
edid_set_framebuffer_bits_per_pixel(&edid,
|
|
conf->framebuffer_bits_per_pixel, 0);
|
|
rkvop_mode_set(vop_id, &edid, detected_mode);
|
|
|
|
rkvop_prepare(vop_id, &edid);
|
|
|
|
switch (detected_mode) {
|
|
case VOP_MODE_HDMI:
|
|
/* should not be here before HDMI supported */
|
|
return;
|
|
case VOP_MODE_EDP:
|
|
default:
|
|
/* will enable edp in depthcharge */
|
|
if (rk_edp_prepare())
|
|
goto edp_error;
|
|
mainboard_power_on_backlight();
|
|
break;
|
|
}
|
|
|
|
set_vbe_mode_info_valid(&edid, (uintptr_t)0);
|
|
return;
|
|
|
|
edp_error:
|
|
if (retry_count++ < 3) {
|
|
/* rst edp */
|
|
write32(&cru_ptr->softrst_con[17],
|
|
RK_SETBITS(1 << 12 | 1 << 13));
|
|
udelay(1);
|
|
write32(&cru_ptr->softrst_con[17],
|
|
RK_CLRBITS(1 << 12 | 1 << 13));
|
|
goto retry_edp;
|
|
}
|
|
printk(BIOS_WARNING, "epd initial error\n");
|
|
}
|