c445b4fc77
A long time ago many Chrome OS boards had pages full of duplicated boilerplate code for the fill_lb_gpios() function, and we spent a lot of time bikeshedding a proper solution that passes a table of lb_gpio structs which can be concisely written with a static struct initializer in http://crosreview.com/234648. Unfortunately we never really finished that patch and in the mean time a different solution using the fill_lb_gpio() helper got standardized onto most boards. Still, that solution is not quite as clean and concise as the one we had already designed, and it also wasn't applied consistently to all recent boards (causing more boards with bad code to get added afterwards). This patch switches all boards newer than Link to the better solution and also adds some nicer debug output for the GPIOs while I'm there. If more boards need to be converted from fill_lb_gpio() to this model later (e.g. from a branch), it's quite easy to do with: s/fill_lb_gpio(gpio++,\n\?\s*\([^,]*\),\n\?\s*\([^,]*\),\n\?\s*\([^,]*\),\n\?\s*\([^,]*\));/\t{\1, \2, \4, \3},/ Based on a patch by Furquan Shaikh <furquan@google.com>. BUG=None BRANCH=None TEST=Booted on Oak. Ran abuild -x. Change-Id: I449974d1c75c8ed187f5e10935495b2f03725811 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/14226 Tested-by: build bot (Jenkins) Reviewed-by: David Hendricks <dhendrix@chromium.org>
89 lines
2.2 KiB
C
89 lines
2.2 KiB
C
/*
|
|
* This file is part of the coreboot project.
|
|
*
|
|
* Copyright (C) 2012 Google Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <string.h>
|
|
#include <bootmode.h>
|
|
#include <arch/io.h>
|
|
#include <device/device.h>
|
|
#include <device/pci.h>
|
|
#include <southbridge/intel/lynxpoint/pch.h>
|
|
#include <southbridge/intel/common/gpio.h>
|
|
|
|
#if CONFIG_EC_GOOGLE_CHROMEEC
|
|
#include "ec.h"
|
|
#include <ec/google/chromeec/ec.h>
|
|
#endif
|
|
|
|
#ifndef __PRE_RAM__
|
|
#include <boot/coreboot_tables.h>
|
|
|
|
void fill_lb_gpios(struct lb_gpios *gpios)
|
|
{
|
|
struct lb_gpio chromeos_gpios[] = {
|
|
{58, ACTIVE_HIGH, 0, "write protect"},
|
|
{-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"},
|
|
{-1, ACTIVE_HIGH, get_developer_mode_switch(), "developer"},
|
|
{-1, ACTIVE_HIGH, get_lid_switch(), "lid"},
|
|
{-1, ACTIVE_HIGH, 0, "power"},
|
|
{-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"},
|
|
};
|
|
lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
|
|
}
|
|
#endif
|
|
|
|
int get_lid_switch(void)
|
|
{
|
|
#if CONFIG_EC_GOOGLE_CHROMEEC
|
|
u8 ec_switches = inb(EC_LPC_ADDR_MEMMAP + EC_MEMMAP_SWITCHES);
|
|
|
|
return !!(ec_switches & EC_SWITCH_LID_OPEN);
|
|
#else
|
|
return 0;
|
|
#endif
|
|
}
|
|
|
|
/* The dev-switch is virtual */
|
|
int get_developer_mode_switch(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
/* There are actually two recovery switches. One is the magic keyboard chord,
|
|
* the other is driven by Servo. */
|
|
int get_recovery_mode_switch(void)
|
|
{
|
|
#if CONFIG_EC_GOOGLE_CHROMEEC
|
|
u8 ec_switches = inb(EC_LPC_ADDR_MEMMAP + EC_MEMMAP_SWITCHES);
|
|
u32 ec_events;
|
|
|
|
/* If a switch is set, we don't need to look at events. */
|
|
if (ec_switches & (EC_SWITCH_DEDICATED_RECOVERY))
|
|
return 1;
|
|
|
|
/* Else check if the EC has posted the keyboard recovery event. */
|
|
ec_events = google_chromeec_get_events_b();
|
|
|
|
return !!(ec_events &
|
|
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));
|
|
#else
|
|
return 0;
|
|
#endif
|
|
}
|
|
|
|
int get_write_protect_state(void)
|
|
{
|
|
return get_gpio(58);
|
|
}
|