Previously incorrect sets of SATA ports were enabled. There are no publically available schematics, but I am almost certain the new values are correct. The original 0x33 value was carlessly copy pasted, and only enables ports 0, 1, 4, 5, leaving 2, 3 disabled. On the SFF, with 0x33 only the first 2 ports worked. I have verified by plugging in devices under the stock firmware that 0, 1, 2 are the ones that should be enabled, so setting the value to 0x7 per datasheet. This was also tested in practice to work. I don't have an MT, but I was told the two white ports didn't work with 0x33, so those are most certainly ports 3, 4, hence me setting the value to 0xf. If the MT's working ports are port 0, 1 on the PCH this is correct. Signed-off-by: Mate Kukri <kukri.mate@gmail.com> Change-Id: I32cb236b8f8140fba4a04c23161363d21741dcbc Reviewed-on: https://review.coreboot.org/c/coreboot/+/81550 Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Eric Lai <ericllai@google.com>
81 lines
2.3 KiB
Plaintext
81 lines
2.3 KiB
Plaintext
## SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
chip northbridge/intel/haswell
|
|
# This mainboard has VGA
|
|
register "gpu_ddi_e_connected" = "1"
|
|
|
|
chip cpu/intel/haswell
|
|
device cpu_cluster 0 on ops haswell_cpu_bus_ops end
|
|
end
|
|
|
|
device domain 0 on
|
|
ops haswell_pci_domain_ops
|
|
|
|
subsystemid 0x1028 0x05a5 inherit
|
|
|
|
device pci 00.0 on end # Host bridge
|
|
device pci 01.0 on end # PCIe graphics
|
|
device pci 02.0 on end # VGA controller
|
|
device pci 03.0 on end # Mini-HD audio
|
|
|
|
chip southbridge/intel/lynxpoint
|
|
register "gen1_dec" = "0x007c0a01"
|
|
register "gen2_dec" = "0x007c0901"
|
|
register "gen3_dec" = "0x003c07e1"
|
|
register "gen4_dec" = "0x001c0901"
|
|
register "sata_port_map" = "0x7"
|
|
|
|
device pci 14.0 on end # xHCI controller
|
|
device pci 16.0 on end # Management Engine interface 1
|
|
device pci 16.1 off end # Management Engine interface 2
|
|
device pci 16.2 off end # Management Engine IDE-R
|
|
device pci 16.3 on end # Management Engine KT
|
|
device pci 19.0 on # Intel Gigabit Ethernet
|
|
subsystemid 0x1028 0x05a4
|
|
end
|
|
device pci 1a.0 on end # EHCI controller #2
|
|
device pci 1b.0 on end # HD audio controller
|
|
device pci 1c.0 off end
|
|
device pci 1c.1 off end
|
|
device pci 1c.2 off end
|
|
device pci 1c.3 off end
|
|
device pci 1c.4 on end # PCIe 4x slot
|
|
device pci 1c.5 off end
|
|
device pci 1c.6 off end
|
|
device pci 1c.7 off end
|
|
device pci 1d.0 on end # EHCI controller #1
|
|
device pci 1f.0 on # LPC bridge
|
|
chip superio/smsc/sch555x
|
|
device pnp 2e.0 on # EMI
|
|
io 0x60 = 0xa00
|
|
end
|
|
device pnp 2e.1 on # 8042
|
|
io 0x60 = 0x60
|
|
irq 0x0f = 0
|
|
irq 0x70 = 1
|
|
irq 0x72 = 12
|
|
end
|
|
device pnp 2e.7 on # UART1
|
|
io 0x60 = 0x3f8
|
|
irq 0x0f = 2
|
|
irq 0x70 = 4
|
|
end
|
|
device pnp 2e.8 off end # UART2
|
|
device pnp 2e.c on # LPC interface
|
|
io 0x60 = 0x2e
|
|
end
|
|
device pnp 2e.a on # Runtime registers
|
|
io 0x60 = 0xa40
|
|
end
|
|
device pnp 2e.b off end # Floppy Controller
|
|
device pnp 2e.11 off end # Parallel Port
|
|
end
|
|
end
|
|
device pci 1f.2 on end # SATA controller 1
|
|
device pci 1f.3 on end # SMBus
|
|
device pci 1f.5 off end # SATA controller 2
|
|
device pci 1f.6 off end # Thermal
|
|
end
|
|
end
|
|
end
|