Because we had no stack on romcc boards, we had a separate, not as powerful clone of printk: print_*. Back in the day, like more than half a decade ago, we migrated a lot of boards to printk, but we never cleaned up the existing code to be consistent. Instead, we worked around the problem with a very messy console.h (nowadays the mess is hidden in romstage_console.c and early_print.h) This patch cleans up the generic code pieces to use printk() on all non-ROMCC boards. Our two remaining ROMCC boards are fixed up in this commit: bifferos/bifferboard and dmp/vortex86ex. Change-Id: I16676eeabe5c892c8e3c9f3c0cd3bae2e8fd74b6 Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Reviewed-on: http://review.coreboot.org/8115 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-by: Andrew Wu <arw@dmp.com.tw> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
		
			
				
	
	
		
			48 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			48 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#include <lib.h> /* Prototypes */
 | 
						|
 | 
						|
/* Setup SDRAM */
 | 
						|
#if CONFIG_RAMINIT_SYSINFO
 | 
						|
void sdram_initialize(int controllers, const struct mem_controller *ctrl, void *sysinfo)
 | 
						|
#else
 | 
						|
void sdram_initialize(int controllers, const struct mem_controller *ctrl)
 | 
						|
#endif
 | 
						|
{
 | 
						|
	int i;
 | 
						|
	/* Set the registers we can set once to reasonable values */
 | 
						|
	for(i = 0; i < controllers; i++) {
 | 
						|
		printk(BIOS_DEBUG, "Ram1.%02x\n", i);
 | 
						|
 | 
						|
	#if CONFIG_RAMINIT_SYSINFO
 | 
						|
		sdram_set_registers(ctrl + i, sysinfo);
 | 
						|
	#else
 | 
						|
		sdram_set_registers(ctrl + i);
 | 
						|
	#endif
 | 
						|
	}
 | 
						|
 | 
						|
	/* Now setup those things we can auto detect */
 | 
						|
	for(i = 0; i < controllers; i++) {
 | 
						|
		printk(BIOS_DEBUG, "Ram2.%02x\n", i);
 | 
						|
 | 
						|
	#if CONFIG_RAMINIT_SYSINFO
 | 
						|
		sdram_set_spd_registers(ctrl + i, sysinfo);
 | 
						|
	#else
 | 
						|
                sdram_set_spd_registers(ctrl + i);
 | 
						|
	#endif
 | 
						|
 | 
						|
	}
 | 
						|
 | 
						|
	/* Now that everything is setup enable the SDRAM.
 | 
						|
	 * Some chipsets do the work for us while on others
 | 
						|
	 * we need to it by hand.
 | 
						|
	 */
 | 
						|
	printk(BIOS_DEBUG, "Ram3\n");
 | 
						|
 | 
						|
	#if CONFIG_RAMINIT_SYSINFO
 | 
						|
	sdram_enable(controllers, ctrl, sysinfo);
 | 
						|
	#else
 | 
						|
	sdram_enable(controllers, ctrl);
 | 
						|
	#endif
 | 
						|
 | 
						|
	printk(BIOS_DEBUG, "Ram4\n");
 | 
						|
}
 |