Because we had no stack on romcc boards, we had a separate, not as powerful clone of printk: print_*. Back in the day, like more than half a decade ago, we migrated a lot of boards to printk, but we never cleaned up the existing code to be consistent. instead, we worked around the problem with a very messy console.h (nowadays the mess is hidden in romstage_console.c and early_print.h) This patch cleans up the northbridge code to use printk() on all non-ROMCC boards. Change-Id: I4a36cd965c58aae65d74ce1e697dc0d0f58f47a1 Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Reviewed-on: http://review.coreboot.org/7856 Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Tested-by: build bot (Jenkins)
53 lines
1.1 KiB
C
53 lines
1.1 KiB
C
#include <console/console.h>
|
|
#include <arch/io.h>
|
|
#include <spd.h>
|
|
#include "raminit.h"
|
|
#include <spd.h>
|
|
#include <console/console.h>
|
|
|
|
#if CONFIG_DEBUG_RAM_SETUP
|
|
void dump_spd_registers(void)
|
|
{
|
|
int i;
|
|
printk(BIOS_DEBUG, "\n");
|
|
for(i = 0; i < DIMM_SOCKETS; i++) {
|
|
unsigned device;
|
|
device = DIMM0 + i;
|
|
if (device) {
|
|
int j;
|
|
printk(BIOS_DEBUG, "DIMM %d: %02x", i, device);
|
|
for(j = 0; j < 256; j++) {
|
|
int status;
|
|
unsigned char byte;
|
|
if ((j & 0xf) == 0) {
|
|
printk(BIOS_DEBUG, "\n%02x: ", j);
|
|
}
|
|
status = spd_read_byte(device, j);
|
|
if (status < 0) {
|
|
printk(BIOS_DEBUG, "bad device\n");
|
|
break;
|
|
}
|
|
byte = status & 0xff;
|
|
printk(BIOS_DEBUG, "%02x ", byte);
|
|
}
|
|
printk(BIOS_DEBUG, "\n");
|
|
}
|
|
}
|
|
}
|
|
|
|
void dump_pci_device(unsigned dev)
|
|
{
|
|
int i;
|
|
printk(BIOS_DEBUG, "PCI: %02x:%02x.%02x\n", (dev >> 20) & 0xff, (dev >> 15) & 0x1f, (dev >> 12) & 7);
|
|
|
|
for (i = 0; i <= 255; i++) {
|
|
unsigned char val;
|
|
val = pci_read_config8(dev, i);
|
|
if ((i & 0x0f) == 0)
|
|
printk(BIOS_DEBUG, "%02x: %02x", i, val);
|
|
if ((i & 0x0f) == 0x0f)
|
|
printk(BIOS_DEBUG, "\n");
|
|
}
|
|
}
|
|
#endif
|