While having select statements in Kconfig.name files is valid in the syntax of the Kconfig language, having the selections split between the normal Kconfig file and Kconfig.name files makes it harder to see what's going on. Kconfig.name files will now be limited to their original purpose of selecting a particular board or board variant, not actually configuring that board. Signed-off-by: Martin Roth <gaumless@gmail.com> Change-Id: I2aab78e296f2958e77a938b1afa40a25a6aa82b0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78972 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune@9elements.com> Reviewed-by: Julius Werner <jwerner@chromium.org>
		
			
				
	
	
		
			17 lines
		
	
	
		
			361 B
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			17 lines
		
	
	
		
			361 B
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
| #!/usr/bin/env sh
 | |
| # SPDX-License-Identifier: GPL-2.0-or-later
 | |
| #
 | |
| # DESCR: Check that boards don't use select Kconfig.name
 | |
| 
 | |
| export LC_ALL=C
 | |
| FAIL=0
 | |
| 
 | |
| for board in src/mainboard/*/*; do
 | |
|   if [ -f ${board}/Kconfig.name ] && grep -q "select " "${board}/Kconfig.name"; then
 | |
|     echo "Mainboard ${board} uses 'select' in Kconfig.name"
 | |
|     FAIL=1
 | |
|   fi
 | |
| done
 | |
| 
 | |
| exit ${FAIL}
 |