90afa3c28c
The `ASSERT` macro is already defined in `src/include/assert.h`, and
AGESA's definition is never used. On Asus A88XM-E, toggling the value of
the `IDSOPT_ASSERT_ENABLED` macro does not change the resulting binary
when using reproducible builds. Attempting to use AGESA's definition of
the `ASSERT` macro results in build errors:
In file included from src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c:56:
src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c: In function 'GetType4Type7Info':
src/vendorcode/amd/agesa/f15tn/Include/Ids.h:371:33: error: statement with no effect [-Werror=unused-value]
#define ASSERT(conditional) ((conditional) ? 0 : IdsAssert (STOP_CODE));
Given that coreboot's definition of `ASSERT` is more useful, drop
AGESA's broken definition and the useless `IDSOPT_ASSERT_ENABLED` macro.
Also remove the `IdsAssert` function, as it is no longer used anywhere.
Tested with BUILD_TIMELESS=1, Asus A88XM-E remains identical.
Change-Id: Ia4e5dbfd3d2e5cec979b8b16fbc11d1ca8a0661e
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/53983
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
37 lines
853 B
C
37 lines
853 B
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
|
|
/**
|
|
* @file
|
|
*
|
|
* IDS Option File
|
|
*
|
|
* This file is used to switch on/off IDS features.
|
|
*
|
|
*/
|
|
#ifndef _OPTION_IDS_H_
|
|
#define _OPTION_IDS_H_
|
|
|
|
/**
|
|
*
|
|
* This file generates the defaults tables for the Integrated Debug Support
|
|
* Module. The documented build options are imported from a user controlled
|
|
* file for processing. The build options for the Integrated Debug Support
|
|
* Module are listed below:
|
|
*
|
|
* IDSOPT_IDS_ENABLED
|
|
* IDSOPT_ERROR_TRAP_ENABLED
|
|
* IDSOPT_CONTROL_ENABLED
|
|
* IDSOPT_TRACING_ENABLED
|
|
* IDSOPT_PERF_ANALYSIS
|
|
* IDSOPT_CAR_CORRUPTION_CHECK_ENABLED
|
|
*
|
|
**/
|
|
|
|
#define IDSOPT_IDS_ENABLED TRUE
|
|
//#define IDSOPT_CONTROL_ENABLED TRUE
|
|
//#define IDSOPT_TRACING_ENABLED TRUE
|
|
#define IDSOPT_TRACING_CONSOLE_SERIALPORT TRUE
|
|
//#define IDSOPT_PERF_ANALYSIS TRUE
|
|
|
|
#endif
|