Documentation is scarce on the matter, however the related coreboot code suggests that after the ACK, the keyboard also sends the result of the self test (passed/failed). It looks like this result is never consumed here, probably resulting in further confusion for later com- mands. Let's revert this for now (if it's not too late for the 4.10 release) and break things later again. IMHO, due to the fact that there are dozens of different keyboard controller and keyboard implementations and no accurate specification followed, such changes should be tested on a lot of hardware before merge. This reverts commita99ed13e33. This reverts commit7ae606f57f. Change-Id: I4d4304d5d8a01e013feac61016c59bcaeea81140 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33244 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Martin Kepplinger <martink@posteo.de> Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Furquan Shaikh <furquan@google.com>
		
			
				
	
	
		
			70 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			70 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * This file is part of the libpayload project.
 | |
|  *
 | |
|  * Copyright 2018 Google LLC
 | |
|  *
 | |
|  * Redistribution and use in source and binary forms, with or without
 | |
|  * modification, are permitted provided that the following conditions
 | |
|  * are met:
 | |
|  * 1. Redistributions of source code must retain the above copyright
 | |
|  *    notice, this list of conditions and the following disclaimer.
 | |
|  * 2. Redistributions in binary form must reproduce the above copyright
 | |
|  *    notice, this list of conditions and the following disclaimer in the
 | |
|  *    documentation and/or other materials provided with the distribution.
 | |
|  * 3. The name of the author may not be used to endorse or promote products
 | |
|  *    derived from this software without specific prior written permission.
 | |
|  *
 | |
|  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
 | |
|  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 | |
|  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 | |
|  * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
 | |
|  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 | |
|  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
 | |
|  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 | |
|  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 | |
|  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 | |
|  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 | |
|  * SUCH DAMAGE.
 | |
|  */
 | |
| 
 | |
| #ifndef __DRIVERS_I8042_I8042_H__
 | |
| #define __DRIVERS_I8042_I8042_H__
 | |
| 
 | |
| /* Port 0x64 commands */
 | |
| #define I8042_CMD_RD_CMD_BYTE		0x20
 | |
| #define I8042_CMD_WR_CMD_BYTE		0x60
 | |
| #define I8042_CMD_DIS_AUX		0xa7
 | |
| #define I8042_CMD_EN_AUX		0xa8
 | |
| #define I8042_CMD_AUX_TEST		0xa9
 | |
| #define I8042_CMD_SELF_TEST		0xaa
 | |
| #define   I8042_SELF_TEST_RSP		0x55
 | |
| #define I8042_CMD_KB_TEST		0xab
 | |
| #define I8042_CMD_DIAG_DUMP		0xac
 | |
| #define I8042_CMD_DIS_KB		0xad
 | |
| #define I8042_CMD_EN_KB			0xae
 | |
| #define I8042_CMD_RD_INPUT_PORT		0xc0
 | |
| #define I8042_CMD_RD_OUTPUT_PORT	0xd0
 | |
| #define I8042_CMD_WR_OUTPUT_PORT	0xd1
 | |
| #define I8042_CMD_RD_TEST_INPUTS	0xe0
 | |
| 
 | |
| /* Port 0x60 keyboard commands */
 | |
| #define I8042_KBCMD_SET_MODE_IND	0xed
 | |
| #define   I8042_MODE_CAPS_LOCK_ON	(1 << 2)
 | |
| #define   I8042_MODE_CAPS_LOCK_OFF	(0 << 2)
 | |
| #define   I8042_MODE_NUM_LOCK_ON	(1 << 1)
 | |
| #define   I8042_MODE_NUM_LOCK_OFF	(0 << 1)
 | |
| #define   I8042_MODE_SCROLL_LOCK_ON	(1 << 0)
 | |
| #define   I8042_MODE_SCROLL_LOCK_OFF	(0 << 0)
 | |
| #define I8042_KBCMD_SET_SCANCODE	0xf0
 | |
| #define   I8042_SCANCODE_SET_1		(1)
 | |
| #define   I8042_SCANCODE_SET_2		(2)
 | |
| #define   I8042_SCANCODE_SET_3		(3)
 | |
| #define I8042_KBCMD_SET_TYPEMATIC	0xf3
 | |
| #define I8042_KBCMD_EN			0xf4
 | |
| #define I8042_KBCMD_DEFAULT_DIS		0xf5
 | |
| #define I8042_KBCMD_SET_DEFAULT		0xf6
 | |
| #define I8042_KBCMD_RESEND		0xfe
 | |
| #define I8042_KBCMD_RESET		0xff
 | |
| 
 | |
| #endif /* __DRIVERS_I8042_I8042_H__ */
 |