ae0fb762a2
The "write protect" GPIO's cached value is never actually read after entering depthcharge. Ensure the value from get_write_protect_state() is being transferred accurately, so that we may read this GPIO value in depthcharge without resampling. The cached value of the "recovery" GPIO is read only on certain boards which have a physical recovery switch. Correct some of the values sent to boards which presumably never read the previously incorrect value. Most of these inaccuracies are from non-inverted values on ACTIVE_LOW GPIOs. BUG=b:124141368, b:124192753, chromium:950273 TEST=make clean && make test-abuild BRANCH=none Change-Id: Ic17a98768703d7098480a9233b752fe5b201bd51 Signed-off-by: Joel Kitching <kitching@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32233 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Julius Werner <jwerner@chromium.org>
60 lines
1.6 KiB
C
60 lines
1.6 KiB
C
/*
|
|
* This file is part of the coreboot project.
|
|
*
|
|
* Copyright (C) 2012 Google Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <bootmode.h>
|
|
#include <device/device.h>
|
|
#include <device/pci.h>
|
|
#include <soc/gpio.h>
|
|
#include <vendorcode/google/chromeos/chromeos.h>
|
|
|
|
/* Compile-time settings for recovery mode. */
|
|
#define REC_MODE_SETTING 0
|
|
|
|
#ifndef __PRE_RAM__
|
|
#include <boot/coreboot_tables.h>
|
|
|
|
void fill_lb_gpios(struct lb_gpios *gpios)
|
|
{
|
|
struct lb_gpio chromeos_gpios[] = {
|
|
{-1, ACTIVE_HIGH, get_write_protect_state(), "write protect"},
|
|
{-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"},
|
|
{-1, ACTIVE_HIGH, 1, "lid"}, // force open
|
|
{-1, ACTIVE_HIGH, 0, "power"},
|
|
{-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"},
|
|
};
|
|
lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
|
|
}
|
|
#endif
|
|
|
|
int get_recovery_mode_switch(void)
|
|
{
|
|
return REC_MODE_SETTING;
|
|
}
|
|
|
|
int get_write_protect_state(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static const struct cros_gpio cros_gpios[] = {
|
|
CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
|
|
CROS_GPIO_WP_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
|
|
};
|
|
|
|
void mainboard_chromeos_acpi_generate(void)
|
|
{
|
|
chromeos_acpi_gpio_generate(cros_gpios, ARRAY_SIZE(cros_gpios));
|
|
}
|