b95fc308af
Broadwell and Skylake chipsets, along with a few mainboards were selecting ALWAYS_LOAD_OPROM without making sure that the dependency for that symbol was met as well. Looking at the dependencies for VGA_RUN_ROM, we see: PCI && !PAYLOAD_SEABIOS && !MAINBOARD_DO_NATIVE_VGA_INIT Since ARCH_X86 selects PCI, that's always met here. Since Broadwell and Skylake don't have native VGA init yet, that's not needed. - Make sure that VGA_RUN_ROM is selected as well. - Add dependency on !PAYLOAD_SEABIOS for both ALWAYS_LOAD_OPROM and VGA_RUN_ROM symbols where they're selected. Fixes Kconfig warning for these boards and chipsets: warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && CPU_SPECIFIC_OPTIONS && CPU_SPECIFIC_OPTIONS) selects ALWAYS_LOAD_OPROM which has unmet direct dependencies (VGA_ROM_RUN) Change-Id: I787a87e9467e1fc7afe8b04864b2a89b54824b9f Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: http://review.coreboot.org/11246 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
42 lines
769 B
Plaintext
42 lines
769 B
Plaintext
if BOARD_GOOGLE_RAMBI
|
|
|
|
config BOARD_SPECIFIC_OPTIONS
|
|
def_bool y
|
|
select SOC_INTEL_BAYTRAIL
|
|
select EC_GOOGLE_CHROMEEC
|
|
select EC_SOFTWARE_SYNC
|
|
select VIRTUAL_DEV_SWITCH
|
|
select ENABLE_BUILTIN_COM1
|
|
select BOARD_ROMSIZE_KB_8192
|
|
select HAVE_ACPI_TABLES
|
|
select HAVE_OPTION_TABLE
|
|
select HAVE_ACPI_RESUME
|
|
select MAINBOARD_HAS_CHROMEOS
|
|
select MAINBOARD_HAS_LPC_TPM
|
|
select VGA_ROM_RUN if !PAYLOAD_SEABIOS
|
|
select ALWAYS_LOAD_OPROM if !PAYLOAD_SEABIOS
|
|
select CHROMEOS_VBNV_CMOS
|
|
select LID_SWITCH
|
|
|
|
config MAINBOARD_DIR
|
|
string
|
|
default google/rambi
|
|
|
|
config MAINBOARD_PART_NUMBER
|
|
string
|
|
default "Rambi"
|
|
|
|
config VGA_BIOS_FILE
|
|
string
|
|
default "pci8086,0166.rom"
|
|
|
|
config HAVE_IFD_BIN
|
|
bool
|
|
default n
|
|
|
|
config HAVE_ME_BIN
|
|
bool
|
|
default n
|
|
|
|
endif # BOARD_INTEL_BAYLEYBAY
|