Fix undefined behavior found by clang's -Wshift-sign-overflow, grep, and source inspection. Left shifting an int where the right operand is >= the width of the type is undefined. Add UL suffix since it's safe for unsigned types. Change-Id: Id1ed2252ce3ed052730dd10b24c453c34c2ab4ff Signed-off-by: Ryan Salsamendi <rsalsamendi@hotmail.com> Reviewed-on: https://review.coreboot.org/20465 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
53 lines
1.8 KiB
C
53 lines
1.8 KiB
C
/*
|
|
* This file is part of the coreboot project.
|
|
*
|
|
* Copyright (C) 2012 The Chromium OS Authors. All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; version 2 of
|
|
* the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <arch/io.h>
|
|
#include <stdlib.h>
|
|
#include "haswell.h"
|
|
|
|
#define PCI_DEV_HSW PCI_DEV(0, 0, 0)
|
|
|
|
void intel_northbridge_haswell_finalize_smm(void)
|
|
{
|
|
pci_or_config16(PCI_DEV_HSW, 0x50, 1 << 0); /* GGC */
|
|
pci_or_config32(PCI_DEV_HSW, 0x5c, 1 << 0); /* DPR */
|
|
pci_or_config32(PCI_DEV_HSW, 0x78, 1 << 10); /* ME */
|
|
pci_or_config32(PCI_DEV_HSW, 0x90, 1 << 0); /* REMAPBASE */
|
|
pci_or_config32(PCI_DEV_HSW, 0x98, 1 << 0); /* REMAPLIMIT */
|
|
pci_or_config32(PCI_DEV_HSW, 0xa0, 1 << 0); /* TOM */
|
|
pci_or_config32(PCI_DEV_HSW, 0xa8, 1 << 0); /* TOUUD */
|
|
pci_or_config32(PCI_DEV_HSW, 0xb0, 1 << 0); /* BDSM */
|
|
pci_or_config32(PCI_DEV_HSW, 0xb4, 1 << 0); /* BGSM */
|
|
pci_or_config32(PCI_DEV_HSW, 0xb8, 1 << 0); /* TSEGMB */
|
|
pci_or_config32(PCI_DEV_HSW, 0xbc, 1 << 0); /* TOLUD */
|
|
|
|
MCHBAR32_OR(0x5500, 1 << 0); /* PAVP */
|
|
MCHBAR32_OR(0x5f00, 1UL << 31); /* SA PM */
|
|
MCHBAR32_OR(0x6020, 1 << 0); /* UMA GFX */
|
|
MCHBAR32_OR(0x63fc, 1 << 0); /* VTDTRK */
|
|
MCHBAR32_OR(0x6800, 1UL << 31);
|
|
MCHBAR32_OR(0x7000, 1UL << 31);
|
|
MCHBAR32_OR(0x77fc, 1 << 0);
|
|
|
|
/* Memory Controller Lockdown */
|
|
MCHBAR8(0x50fc) = 0x8f;
|
|
|
|
/* Read+write the following */
|
|
MCHBAR32(0x6030) = MCHBAR32(0x6030);
|
|
MCHBAR32(0x6034) = MCHBAR32(0x6034);
|
|
MCHBAR32(0x6008) = MCHBAR32(0x6008);
|
|
}
|