Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin <yidilin@google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Reviewed-by: Jakub Czapiga <czapiga@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
27 lines
503 B
C
27 lines
503 B
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#include <cpu/cpu.h>
|
|
#include <device/device.h>
|
|
|
|
static void qemu_cpu_init(struct device *dev)
|
|
{
|
|
}
|
|
|
|
static struct device_operations cpu_dev_ops = {
|
|
.init = qemu_cpu_init,
|
|
};
|
|
|
|
static const struct cpu_device_id cpu_table[] = {
|
|
{ X86_VENDOR_ANY, 0, 0 },
|
|
CPU_TABLE_END
|
|
};
|
|
|
|
static const struct cpu_driver driver __cpu_driver = {
|
|
.ops = &cpu_dev_ops,
|
|
.id_table = cpu_table,
|
|
};
|
|
|
|
struct chip_operations cpu_qemu_x86_ops = {
|
|
.name = "QEMU x86 CPU",
|
|
};
|