d2be1f11e1
When calculating the offsets of the various binary blobs within the
coreboot.rom file, we noticed that using mawk as the awk tool instead
of using gawk led to build issues. This was finally traced to the
maximum value of the unsigned long variables within mawk - 0x7fff_ffff.
Because we were doing calculations on values up in the 0xffxxxxxx
range, these numbers would either be turned into floating point values
and printed using scientific notation, or truncated at 0x7fff_ffff.
To fix this, we print the values out as floating point, with no decimal
digits. This works in gawk, mawk, and original-awk and as the testing
below show, seems to be the best way to do this.
printf %u 0xFFFFFFFF | awk '{printf("%.0f %u %d", $1 , $1 , $1 )}'
mawk: 4294967295 2147483647 2147483647
original-awk: 4294967295 2147483648 4294967295
gawk: 4294967295 4294967295 4294967295
The issue of %d not matching gawk and original-awk has been reported
to ubuntu.
In the future, I'd recommend that whenever awk is used, a format is
specified. It doesn't seem that we can count on the representation
being the same between the different versions.
Change-Id: I7b6b821c8ab13ad11f72e674ac726a98e8678710
Signed-off-by: Martin Roth <martin.roth@se-eng.com>
Reviewed-on: http://review.coreboot.org/2628
Reviewed-by: Dave Frodin <dave.frodin@se-eng.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
108 lines
3.7 KiB
Makefile
108 lines
3.7 KiB
Makefile
ramstage-y += hudson.c
|
|
ramstage-y += usb.c
|
|
ramstage-y += lpc.c
|
|
ramstage-y += sm.c
|
|
ramstage-y += ide.c
|
|
ramstage-y += sata.c
|
|
ramstage-y += hda.c
|
|
ramstage-y += pci.c
|
|
ramstage-y += pcie.c
|
|
ramstage-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c
|
|
ramstage-y += reset.c
|
|
romstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c
|
|
ramstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c
|
|
romstage-y += early_setup.c
|
|
|
|
ramstage-$(CONFIG_HAVE_ACPI_RESUME) += spi.c
|
|
|
|
# ROMSIG At ROMBASE + 0x20000:
|
|
# +-----------+---------------+----------------+------------+
|
|
# |0x55AA55AA |EC ROM Address |GEC ROM Address |USB3 ROM |
|
|
# +-----------+---------------+----------------+------------+
|
|
# EC ROM should be 64K aligned.
|
|
HUDSON_FWM_POSITION=$(shell printf %u $(CONFIG_HUDSON_FWM_POSITION))
|
|
|
|
#assume the cbfs header is less than 128 bytes.
|
|
ROMSIG_SIZE=16
|
|
ifeq ($(CONFIG_HUDSON_XHCI_FWM), y)
|
|
HUDSON_XHCI_POSITION=$(shell echo $(HUDSON_FWM_POSITION) $(ROMSIG_SIZE) 128 \
|
|
| awk '{printf("%.0f", $$1 + $$2 + $$3)}')
|
|
XHCI_FWM_SIZE=$(word 5,$(shell ls -l $(CONFIG_HUDSON_XHCI_FWM_FILE)))
|
|
else
|
|
HUDSON_XHCI_POSITION=0
|
|
XHCI_FWM_SIZE=0
|
|
endif
|
|
|
|
ifeq ($(CONFIG_HUDSON_GEC_FWM), y)
|
|
HUDSON_GEC_POSITION=$(shell echo $(HUDSON_FWM_POSITION) $(ROMSIG_SIZE) 128 \
|
|
$(XHCI_FWM_SIZE) 128 \
|
|
| awk '{printf("%.0f", $$1 + $$2 + $$3 + $$4 + $$5)}')
|
|
GEC_FWM_SIZE=$(word 5,$(shell ls -l $(CONFIG_HUDSON_GEC_FWM_FILE)))
|
|
else
|
|
HUDSON_GEC_POSITION=0
|
|
GEC_FWM_SIZE=0
|
|
endif
|
|
|
|
ifeq ($(CONFIG_HUDSON_IMC_FWM), y)
|
|
HUDSON_IMC_POSITION_UNALIGN=$(shell echo $(HUDSON_FWM_POSITION) \
|
|
$(ROMSIG_SIZE) 128 $(XHCI_FWM_SIZE) 128 $(GEC_FWM_SIZE) 128 65535 \
|
|
| awk '{printf("%.0f", $$1 + $$2 + $$3 + $$4 + $$5 + $$6 + $$7 + $$8)}')
|
|
HUDSON_IMC_POSITION=$(shell echo $(HUDSON_IMC_POSITION_UNALIGN) \
|
|
| awk '{printf("%.0f", $$1 - $$1 % 65536)}')
|
|
else
|
|
HUDSON_IMC_POSITION=0
|
|
endif
|
|
|
|
$(obj)/coreboot_hudson_romsig.bin: $(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \
|
|
$(call strip_quotes, $(CONFIG_HUDSON_IMC_FWM_FILE)) \
|
|
$(call strip_quotes, $(CONFIG_HUDSON_GEC_FWM_FILE)) \
|
|
$(obj)/config.h
|
|
echo " Hudson FW $@"
|
|
for fwm in 1437226410 \
|
|
$(HUDSON_IMC_POSITION) \
|
|
$(HUDSON_GEC_POSITION) \
|
|
$(HUDSON_XHCI_POSITION) ; do \
|
|
echo $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 256, int($$1/256) % 256, int($$1/65536) % 256, int($$1/16777216));}'; \
|
|
done > $@
|
|
|
|
ifeq ($(CONFIG_HUDSON_FWM), y)
|
|
cbfs-files-y += hudson/fwm
|
|
hudson/fwm-file := $(obj)/coreboot_hudson_romsig.bin
|
|
hudson/fwm-position := $(HUDSON_FWM_POSITION)
|
|
hudson/fwm-type := raw
|
|
endif
|
|
|
|
ifeq ($(CONFIG_HUDSON_XHCI_FWM), y)
|
|
cbfs-files-y += hudson/xhci
|
|
hudson/xhci-file := $(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE))
|
|
hudson/xhci-position := $(HUDSON_XHCI_POSITION)
|
|
hudson/xhci-type := raw
|
|
hudson/xhci-required := Hudson XHCI firmware (available in coreboot/3rdparty if enabled)
|
|
endif
|
|
|
|
ifeq ($(CONFIG_HUDSON_IMC_FWM), y)
|
|
cbfs-files-y += hudson/imc
|
|
hudson/imc-file := $(call strip_quotes, $(CONFIG_HUDSON_IMC_FWM_FILE))
|
|
hudson/imc-position := $(HUDSON_IMC_POSITION)
|
|
hudson/imc-type := raw
|
|
hudson/imc-required := Hudson IMC Firmware (available in coreboot/3rdparty if enabled)
|
|
endif
|
|
|
|
ifeq ($(CONFIG_HUDSON_GEC_FWM), y)
|
|
cbfs-files-y += hudson/gec
|
|
hudson/gec-file := $(call strip_quotes, $(CONFIG_HUDSON_GEC_FWM_FILE))
|
|
hudson/gec-position := $(HUDSON_GEC_POSITION)
|
|
hudson/gec-type := raw
|
|
hudson/gec-required := Hudson Gigabit Ethernet Controller Firmware (Contact your AMD representative)
|
|
endif
|
|
|
|
#ifeq ($(CONFIG_HUDSON_SATA_AHCI), y)
|
|
ifdef CONFIG_HUDSON_AHCI_ROM
|
|
stripped_ahci_rom_id = $(call strip_quotes,$(CONFIG_AHCI_ROM_ID))
|
|
cbfs-files-y += pci$(stripped_ahci_rom_id).rom
|
|
pci$(stripped_ahci_rom_id).rom-file := $(call strip_quotes,$(CONFIG_AHCI_ROM_FILE))
|
|
pci$(stripped_ahci_rom_id).rom-type := optionrom
|
|
pci$(stripped_ahci_rom_id).rom-required := Hudson AHCI Option ROM (Contact your AMD representative)
|
|
#endif
|
|
endif
|