dafc6194a0
When no HOB list is found, not only adding the resources reported by the FSP were skipped, but also adding the GNB IOAPIC resource was skipped. Fix this bug by moving the reporting of the GNB IOAPIC resource before the resources reported in the FSP HOBs to not skip the IOAPIC resource when there's no HOB list. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I9174c8d7e5e94144187d27210e12f2dca3a6010f Reviewed-on: https://review.coreboot.org/c/coreboot/+/69460 Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
223 lines
8.2 KiB
C
223 lines
8.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
|
|
#include <acpi/acpigen.h>
|
|
#include <amdblocks/acpi.h>
|
|
#include <amdblocks/alib.h>
|
|
#include <amdblocks/memmap.h>
|
|
#include <amdblocks/ioapic.h>
|
|
#include <arch/ioapic.h>
|
|
#include <assert.h>
|
|
#include <cbmem.h>
|
|
#include <console/console.h>
|
|
#include <cpu/amd/msr.h>
|
|
#include <device/device.h>
|
|
#include <device/pci.h>
|
|
#include <fsp/util.h>
|
|
#include <stdint.h>
|
|
#include <soc/iomap.h>
|
|
#include "chip.h"
|
|
|
|
#define DPTC_TOTAL_UPDATE_PARAMS 4
|
|
|
|
struct dptc_input {
|
|
uint16_t size;
|
|
struct alib_dptc_param params[DPTC_TOTAL_UPDATE_PARAMS];
|
|
} __packed;
|
|
|
|
#define DPTC_INPUTS(_thermctllmit, _sustained, _fast, _slow) \
|
|
{ \
|
|
.size = sizeof(struct dptc_input), \
|
|
.params = { \
|
|
{ \
|
|
.id = ALIB_DPTC_THERMAL_CONTROL_LIMIT_ID, \
|
|
.value = _thermctllmit, \
|
|
}, \
|
|
{ \
|
|
.id = ALIB_DPTC_SUSTAINED_POWER_LIMIT_ID, \
|
|
.value = _sustained, \
|
|
}, \
|
|
{ \
|
|
.id = ALIB_DPTC_FAST_PPT_LIMIT_ID, \
|
|
.value = _fast, \
|
|
}, \
|
|
{ \
|
|
.id = ALIB_DPTC_SLOW_PPT_LIMIT_ID, \
|
|
.value = _slow, \
|
|
}, \
|
|
}, \
|
|
}
|
|
/*
|
|
*
|
|
* +--------------------------------+
|
|
* | |
|
|
* | |
|
|
* | |
|
|
* | |
|
|
* | |
|
|
* | |
|
|
* | |
|
|
* reserved_dram_end +--------------------------------+
|
|
* | |
|
|
* | verstage (if reqd) |
|
|
* | (VERSTAGE_SIZE) |
|
|
* +--------------------------------+ VERSTAGE_ADDR
|
|
* | |
|
|
* | FSP-M |
|
|
* | (FSP_M_SIZE) |
|
|
* +--------------------------------+ FSP_M_ADDR
|
|
* | romstage |
|
|
* | (ROMSTAGE_SIZE) |
|
|
* +--------------------------------+ ROMSTAGE_ADDR = BOOTBLOCK_END
|
|
* | | X86_RESET_VECTOR = BOOTBLOCK_END - 0x10
|
|
* | bootblock |
|
|
* | (C_ENV_BOOTBLOCK_SIZE) |
|
|
* +--------------------------------+ BOOTBLOCK_ADDR = BOOTBLOCK_END - C_ENV_BOOTBLOCK_SIZE
|
|
* | Unused hole |
|
|
* | (86KiB) |
|
|
* +--------------------------------+
|
|
* | FMAP cache (FMAP_SIZE) |
|
|
* +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE + 0x200
|
|
* | Early Timestamp region (512B) |
|
|
* +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE
|
|
* | Preram CBMEM console |
|
|
* | (PRERAM_CBMEM_CONSOLE_SIZE) |
|
|
* +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE
|
|
* | PSP shared (vboot workbuf) |
|
|
* | (PSP_SHAREDMEM_SIZE) |
|
|
* +--------------------------------+ PSP_SHAREDMEM_BASE
|
|
* | APOB (64KiB) |
|
|
* +--------------------------------+ PSP_APOB_DRAM_ADDRESS
|
|
* | Early BSP stack |
|
|
* | (EARLYRAM_BSP_STACK_SIZE) |
|
|
* reserved_dram_start +--------------------------------+ EARLY_RESERVED_DRAM_BASE
|
|
* | DRAM |
|
|
* +--------------------------------+ 0x100000
|
|
* | Option ROM |
|
|
* +--------------------------------+ 0xc0000
|
|
* | Legacy VGA |
|
|
* +--------------------------------+ 0xa0000
|
|
* | DRAM |
|
|
* +--------------------------------+ 0x0
|
|
*/
|
|
static void read_resources(struct device *dev)
|
|
{
|
|
uint32_t mem_usable = (uintptr_t)cbmem_top();
|
|
unsigned int idx = 0;
|
|
const struct hob_header *hob = fsp_get_hob_list();
|
|
const struct hob_resource *res;
|
|
struct resource *gnb_apic;
|
|
|
|
uintptr_t early_reserved_dram_start, early_reserved_dram_end;
|
|
const struct memmap_early_dram *e = memmap_get_early_dram_usage();
|
|
|
|
early_reserved_dram_start = e->base;
|
|
early_reserved_dram_end = e->base + e->size;
|
|
|
|
/* The root complex has no PCI BARs implemented, so there's no need to call
|
|
pci_dev_read_resources for it */
|
|
|
|
/* 0x0 - 0x9ffff */
|
|
ram_resource_kb(dev, idx++, 0, 0xa0000 / KiB);
|
|
|
|
/* 0xa0000 - 0xbffff: legacy VGA */
|
|
mmio_resource_kb(dev, idx++, 0xa0000 / KiB, 0x20000 / KiB);
|
|
|
|
/* 0xc0000 - 0xfffff: Option ROM */
|
|
reserved_ram_resource_kb(dev, idx++, 0xc0000 / KiB, 0x40000 / KiB);
|
|
|
|
/* 1MB - bottom of DRAM reserved for early coreboot usage */
|
|
ram_resource_kb(dev, idx++, (1 * MiB) / KiB,
|
|
(early_reserved_dram_start - (1 * MiB)) / KiB);
|
|
|
|
/* DRAM reserved for early coreboot usage */
|
|
reserved_ram_resource_kb(dev, idx++, early_reserved_dram_start / KiB,
|
|
(early_reserved_dram_end - early_reserved_dram_start) / KiB);
|
|
|
|
/* top of DRAM consumed early - low top usable RAM
|
|
* cbmem_top() accounts for low UMA and TSEG if they are used. */
|
|
ram_resource_kb(dev, idx++, early_reserved_dram_end / KiB,
|
|
(mem_usable - early_reserved_dram_end) / KiB);
|
|
|
|
mmconf_resource(dev, idx++);
|
|
|
|
/* GNB IOAPIC resource */
|
|
gnb_apic = new_resource(dev, idx++);
|
|
gnb_apic->base = GNB_IO_APIC_ADDR;
|
|
gnb_apic->size = 0x00001000;
|
|
gnb_apic->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
|
|
|
|
if (!hob) {
|
|
printk(BIOS_ERR, "%s incomplete because no HOB list was found\n",
|
|
__func__);
|
|
return;
|
|
}
|
|
|
|
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
|
|
|
|
if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR)
|
|
continue;
|
|
|
|
res = fsp_hob_header_to_resource(hob);
|
|
|
|
if (res->type == EFI_RESOURCE_SYSTEM_MEMORY && res->addr < mem_usable)
|
|
continue; /* 0 through low usable was set above */
|
|
if (res->type == EFI_RESOURCE_MEMORY_MAPPED_IO)
|
|
continue; /* Done separately */
|
|
|
|
if (res->type == EFI_RESOURCE_SYSTEM_MEMORY)
|
|
ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB);
|
|
else if (res->type == EFI_RESOURCE_MEMORY_RESERVED)
|
|
reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB);
|
|
else
|
|
printk(BIOS_ERR, "failed to set resources for type %d\n",
|
|
res->type);
|
|
}
|
|
}
|
|
|
|
static void root_complex_init(struct device *dev)
|
|
{
|
|
setup_ioapic((u8 *)GNB_IO_APIC_ADDR, GNB_IOAPIC_ID);
|
|
}
|
|
|
|
static void acipgen_dptci(void)
|
|
{
|
|
const struct soc_amd_picasso_config *config = config_of_soc();
|
|
|
|
/* Normal mode DPTC values. */
|
|
struct dptc_input default_input = DPTC_INPUTS(config->thermctl_limit_degreeC,
|
|
config->sustained_power_limit_mW,
|
|
config->fast_ppt_limit_mW,
|
|
config->slow_ppt_limit_mW);
|
|
acpigen_write_alib_dptc_default((uint8_t *)&default_input, sizeof(default_input));
|
|
|
|
/* Tablet Mode */
|
|
struct dptc_input tablet_mode_input = DPTC_INPUTS(
|
|
config->thermctl_limit_tablet_mode_degreeC,
|
|
config->sustained_power_limit_tablet_mode_mW,
|
|
config->fast_ppt_limit_tablet_mode_mW,
|
|
config->slow_ppt_limit_tablet_mode_mW);
|
|
acpigen_write_alib_dptc_tablet((uint8_t *)&tablet_mode_input,
|
|
sizeof(tablet_mode_input));
|
|
}
|
|
|
|
static void root_complex_fill_ssdt(const struct device *device)
|
|
{
|
|
acpi_fill_root_complex_tom(device);
|
|
if (CONFIG(SOC_AMD_COMMON_BLOCK_ACPI_DPTC))
|
|
acipgen_dptci();
|
|
}
|
|
|
|
static const char *gnb_acpi_name(const struct device *dev)
|
|
{
|
|
return "GNB";
|
|
}
|
|
|
|
struct device_operations picasso_root_complex_operations = {
|
|
.read_resources = read_resources,
|
|
.set_resources = noop_set_resources,
|
|
.enable_resources = pci_dev_enable_resources,
|
|
.init = root_complex_init,
|
|
.acpi_name = gnb_acpi_name,
|
|
.acpi_fill_ssdt = root_complex_fill_ssdt,
|
|
};
|