New fallout vault boy logo

gcc-11 (fedora 35):

/home/kraxel/projects/edk2/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c: In function ?UsbIoBulkTransfer?:
/home/kraxel/projects/edk2/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c:277:12: error: ?UsbHcBulkTransfer? accessing 80 bytes in a region of size 8 [-Werror=stringop-overflow=]

Upstream commit ae8272ef78

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

MdeModulePkg/Application/UiApp/FrontPage.c

@@ -1088,10 +1088,10 @@ UpdateFrontPageBannerStrings (
   EFI_PHYSICAL_ADDRESS              *Table;
   SMBIOS_TABLE_ENTRY_POINT          *EntryPoint;
   SMBIOS_STRUCTURE_POINTER          SmbiosTable;
+  BOOLEAN                           CheckWebcam;
 
   FirmwareConfigurationInformation();
   WarnNoBootableMedia ();
-  WebcamStatus();
 
   Status = EfiGetSystemConfigurationTable (&gEfiSmbiosTableGuid, (VOID **)  &Table);
   if (EFI_ERROR (Status) || Table == NULL) {
@@ -1100,7 +1100,7 @@ UpdateFrontPageBannerStrings (
 
   EntryPoint = (SMBIOS_TABLE_ENTRY_POINT*)Table;
 
-  SmbiosTable = GetSmbiosTableFromType (EntryPoint, EFI_SMBIOS_TYPE_BIOS_INFORMATION , 0);
+  SmbiosTable = GetSmbiosTableFromType (EntryPoint, SMBIOS_TYPE_BIOS_INFORMATION , 0);
   if (SmbiosTable.Raw != NULL) {
     CHAR16 *FwVersion;
     CHAR16 *TmpBuffer;
@@ -1163,6 +1163,24 @@ UpdateFrontPageBannerStrings (
     FreePool (ProductName);
     FreePool (Manufacturer);
   }
+
+  SmbiosTable = GetSmbiosTableFromType (EntryPoint, SMBIOS_TYPE_SYSTEM_ENCLOSURE, 0);
+  if (SmbiosTable.Raw != NULL) {
+      switch (SmbiosTable.Type3->Type) {
+          //TODO: System76 laptops will always report the laptop chassis type,
+          //but we should probably handle all potential types
+          case MiscChassisTypeLapTop:
+              CheckWebcam = TRUE;
+              break;
+          default:
+              CheckWebcam = FALSE;
+              break;
+      }
+  }
+
+  if (CheckWebcam) {
+      WebcamStatus();
+  }
 }
 
 /**

MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c

@@ -285,7 +285,7 @@ UsbHcBulkTransfer (
   IN  UINT8                               DevSpeed,
   IN  UINTN                               MaxPacket,
   IN  UINT8                               BufferNum,
-  IN  OUT VOID                            *Data[EFI_USB_MAX_BULK_BUFFER_NUM],
+  IN  OUT VOID                            *Data[],
   IN  OUT UINTN                           *DataLength,
   IN  OUT UINT8                           *DataToggle,
   IN  UINTN                               TimeOut,

MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h

@@ -149,7 +149,7 @@ UsbHcBulkTransfer (
   IN  UINT8                               DevSpeed,
   IN  UINTN                               MaxPacket,
   IN  UINT8                               BufferNum,
-  IN  OUT VOID                            *Data[EFI_USB_MAX_BULK_BUFFER_NUM],
+  IN  OUT VOID                            *Data[],
   IN  OUT UINTN                           *DataLength,
   IN  OUT UINT8                           *DataToggle,
   IN  UINTN                               TimeOut,

SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c

@@ -4324,7 +4324,7 @@ SecureBootCallback (
   UINT8                           *SecureBootEnable;
   UINT8                           *Pk;
   UINT8                           *SecureBootMode;
-  UINT8                           *SetupMode;
+  //UINT8                           *SetupMode;
   CHAR16                          PromptString[100];
   EFI_DEVICE_PATH_PROTOCOL        *File;
   UINTN                           NameLength;
@@ -4336,7 +4336,7 @@ SecureBootCallback (
   Status             = EFI_SUCCESS;
   SecureBootEnable   = NULL;
   SecureBootMode     = NULL;
-  SetupMode          = NULL;
+  //SetupMode          = NULL;
   File               = NULL;
   EnrollKeyErrorCode = None_Error;