sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables

Browse Source 
At latest edk2 version, there is build failure when building ShellPkg
with VS2012x86, which results from uninitialized local variables.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
This commit is contained in:
Shenglei Zhang
2019-08-15 13:35:42 +08:00
committed by Liming Gao
parent 8906f076de
commit 0154e02dc7
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
View File

@ -121,6 +121,10 @@ VerifyChecksum (
UINT8 Checksum; UINT8 Checksum;
UINTN OriginalAttribute; UINTN OriginalAttribute;
//
// set local variables to suppress incorrect compiler/analyzer warnings
//
OriginalAttribute = 0;
ByteCount = 0; ByteCount = 0;
Checksum = 0; Checksum = 0;
@ -472,6 +476,10 @@ ParseAcpi (
BOOLEAN HighLight; BOOLEAN HighLight;
UINTN OriginalAttribute; UINTN OriginalAttribute;
//
// set local variables to suppress incorrect compiler/analyzer warnings
//
OriginalAttribute = 0;
Offset = 0; Offset = 0;
// Increment the Indent // Increment the Indent

10
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
View File

@ -211,6 +211,10 @@ ProcessTableReportOptions (
BOOLEAN Log; BOOLEAN Log;
BOOLEAN HighLight; BOOLEAN HighLight;
//
// set local variables to suppress incorrect compiler/analyzer warnings
//
OriginalAttribute = 0;
SignaturePtr = (UINT8*)(UINTN)&Signature; SignaturePtr = (UINT8*)(UINTN)&Signature;
Log = FALSE; Log = FALSE;
HighLight = GetColourHighlighting (); HighLight = GetColourHighlighting ();
@ -347,6 +351,12 @@ AcpiView (
PARSE_ACPI_TABLE_PROC RsdpParserProc; PARSE_ACPI_TABLE_PROC RsdpParserProc;
BOOLEAN Trace; BOOLEAN Trace;
//
// set local variables to suppress incorrect compiler/analyzer warnings
//
EfiConfigurationTable = NULL;
OriginalAttribute = 0;
// Search the table for an entry that matches the ACPI Table Guid // Search the table for an entry that matches the ACPI Table Guid
FoundAcpiTable = FALSE; FoundAcpiTable = FALSE;
for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) { for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) {