CryptoPkg/TlsLib: Change the return type of TlsInitialize().
V2: * Correct the commit log. Currently, the return code of OPENSSL_init_ssl(0 or 1) and RandomSeed (TRUE or FALSE) are not checked in TlsInitialize(). Also "VOID" is used as the return type of TlsInitialize(), which can't be used to capture the returned value for error handling. From Long Qin (CryptoPkg owner): The early version of OPENSSL_init_ssl() use the "VOID" as the return value, which was updated to "int" later because the function changes can fail. So, this patch is to change the return type of TlsInitialize() to follow up the OPENSSL_init_ssl() update. Cc: Ye Ting <ting.ye@intel.com> Cc: Long Qin <qin.long@intel.com> Cc: Fu Siyuan <siyuan.fu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com> Reviewed-by: Long Qin <qin.long@intel.com>
This commit is contained in:
@@ -22,26 +22,34 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
|
||||
by SSL/TLS, and initializes the readable error messages.
|
||||
This function must be called before any other action takes places.
|
||||
|
||||
@retval TRUE The OpenSSL library has been initialized.
|
||||
@retval FALSE Failed to initialize the OpenSSL library.
|
||||
|
||||
**/
|
||||
VOID
|
||||
BOOLEAN
|
||||
EFIAPI
|
||||
TlsInitialize (
|
||||
VOID
|
||||
)
|
||||
{
|
||||
INTN Ret;
|
||||
|
||||
//
|
||||
// Performs initialization of crypto and ssl library, and loads required
|
||||
// algorithms.
|
||||
//
|
||||
OPENSSL_init_ssl (
|
||||
OPENSSL_INIT_LOAD_SSL_STRINGS | OPENSSL_INIT_LOAD_CRYPTO_STRINGS,
|
||||
NULL
|
||||
);
|
||||
Ret = OPENSSL_init_ssl (
|
||||
OPENSSL_INIT_LOAD_SSL_STRINGS | OPENSSL_INIT_LOAD_CRYPTO_STRINGS,
|
||||
NULL
|
||||
);
|
||||
if (Ret != 1) {
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
//
|
||||
// Initialize the pseudorandom number generator.
|
||||
//
|
||||
RandomSeed (NULL, 0);
|
||||
return RandomSeed (NULL, 0);
|
||||
}
|
||||
|
||||
/**
|
||||
|
Reference in New Issue
Block a user