sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BaseTools: AutoGen - refactor out a list

Browse Source 
the lists were used in __init__ then converted to sets
instead just use the sets from the begining

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
This commit is contained in:
Carsey, Jaben
2018-04-28 06:32:34 +08:00
committed by Yonghong Zhu
parent def89ed025
commit 0caa769dbb
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py
View File

@ -262,7 +262,6 @@ class VAR_CHECK_PCD_VALID_LIST(VAR_CHECK_PCD_VALID_OBJ):
super(VAR_CHECK_PCD_VALID_LIST, self).__init__(VarOffset, validlist, PcdDataType) super(VAR_CHECK_PCD_VALID_LIST, self).__init__(VarOffset, validlist, PcdDataType)
self.Type = 1 self.Type = 1
valid_num_list = [] valid_num_list = []
data_list = []
for item in self.rawdata: for item in self.rawdata:
valid_num_list.extend(item.split(',')) valid_num_list.extend(item.split(','))
@ -270,12 +269,11 @@ class VAR_CHECK_PCD_VALID_LIST(VAR_CHECK_PCD_VALID_OBJ):
valid_num = valid_num.strip() valid_num = valid_num.strip()
if valid_num.startswith('0x') or valid_num.startswith('0X'): if valid_num.startswith('0x') or valid_num.startswith('0X'):
data_list.append(int(valid_num, 16)) self.data.add(int(valid_num, 16))
else: else:
data_list.append(int(valid_num)) self.data.add(int(valid_num))
self.data = set(data_list)
self.Length = 5 + len(self.data) * self.StorageWidth self.Length = 5 + len(self.data) * self.StorageWidth
@ -284,7 +282,6 @@ class VAR_CHECK_PCD_VALID_RANGE(VAR_CHECK_PCD_VALID_OBJ):
super(VAR_CHECK_PCD_VALID_RANGE, self).__init__(VarOffset, validrange, PcdDataType) super(VAR_CHECK_PCD_VALID_RANGE, self).__init__(VarOffset, validrange, PcdDataType)
self.Type = 2 self.Type = 2
RangeExpr = "" RangeExpr = ""
data_list = []
i = 0 i = 0
for item in self.rawdata: for item in self.rawdata:
if i == 0: if i == 0:
@ -294,8 +291,7 @@ class VAR_CHECK_PCD_VALID_RANGE(VAR_CHECK_PCD_VALID_OBJ):
range_result = RangeExpression(RangeExpr, self.PcdDataType)(True) range_result = RangeExpression(RangeExpr, self.PcdDataType)(True)
for rangelist in range_result: for rangelist in range_result:
for obj in rangelist.pop(): for obj in rangelist.pop():
data_list.append((obj.start, obj.end)) self.data.add((obj.start, obj.end))
self.data = set(data_list)
self.Length = 5 + len(self.data) * 2 * self.StorageWidth self.Length = 5 + len(self.data) * 2 * self.StorageWidth