From 1821dbed1da616637f5c04fe1f5029016f81bd52 Mon Sep 17 00:00:00 2001 From: Eric Dong Date: Mon, 5 Aug 2019 14:38:32 +0800 Subject: [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message. This debug message may be called by BSP and APs. It may caused ASSERT when APs call this debug code. In order to avoid system boot assert, Remove this debug message. Signed-off-by: Eric Dong Reviewed-by: Ray Ni Cc: Laszlo Ersek --- .../CpuFeaturesInitialize.c | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c index 4e97e863c7..fb0535edd6 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c @@ -9,7 +9,6 @@ #include "RegisterCpuFeatures.h" CHAR16 *mDependTypeStr[] = {L"None", L"Thread", L"Core", L"Package", L"Invalid" }; -CHAR16 *mRegisterTypeStr[] = {L"MSR", L"CR", L"MMIO", L"CACHE", L"SEMAP", L"INVALID" }; /** Worker function to save PcdCpuFeaturesCapability. @@ -772,7 +771,6 @@ ProgramProcessorRegister ( UINT32 PackageThreadsCount; UINT32 CurrentThread; UINTN ProcessorIndex; - UINTN ThreadIndex; UINTN ValidThreadCount; UINT32 *ValidCoreCountPerPackage; @@ -785,26 +783,6 @@ ProgramProcessorRegister ( RegisterTableEntry = &RegisterTableEntryHead[Index]; - DEBUG_CODE_BEGIN (); - // - // Wait for the AP to release the MSR spin lock. - // - while (!AcquireSpinLockOrFail (&CpuFlags->ConsoleLogLock)) { - CpuPause (); - } - ThreadIndex = ApLocation->Package * CpuStatus->MaxCoreCount * CpuStatus->MaxThreadCount + - ApLocation->Core * CpuStatus->MaxThreadCount + - ApLocation->Thread; - DEBUG (( - DEBUG_INFO, - "Processor = %08lu, Index %08lu, Type = %s!\n", - (UINT64)ThreadIndex, - (UINT64)Index, - mRegisterTypeStr[MIN ((REGISTER_TYPE)RegisterTableEntry->RegisterType, InvalidReg)] - )); - ReleaseSpinLock (&CpuFlags->ConsoleLogLock); - DEBUG_CODE_END (); - // // Check the type of specified register //