sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix FreePoll() bugs in some places.

Browse Source 
Removed the dependency to MdeModulePkg in the HiiLibFramework
Removed EDK_RELEASE_VERSION and EFI_SPECIFICATION_VERSION in the Framework inf file.
other coding style changes


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7218 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
gdong1
2009-01-08 09:37:30 +00:00
parent fce9f9bba0
commit 1b74e1c7ff
7 changed files with 38 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
IntelFrameworkPkg/Library/FrameworkIfrSupportLib/IfrCommon.c
View File

@@ -804,6 +804,7 @@ ValidateDataFromHiiHandle (
//
VariableData = AllocateZeroPool (SizeOfNvStore);
if (VariableData == NULL) {
FreePool (OldData);
return EFI_OUT_OF_RESOURCES;
}
@@ -832,6 +833,7 @@ ValidateDataFromHiiHandle (
VariableData = AllocatePool (SizeOfNvStore);
if (VariableData == NULL) {
FreePool (OldData);
return EFI_OUT_OF_RESOURCES;
}
@@ -875,7 +877,7 @@ ValidateDataFromHiiHandle (
//
if (!GotMatch) {
*Results = FALSE;
return EFI_SUCCESS;
goto EXIT;
}
break;
@@ -886,7 +888,7 @@ ValidateDataFromHiiHandle (
//
if (VariableData[((FRAMEWORK_EFI_IFR_CHECKBOX *) &RawData[Index])->QuestionId] > 1) {
*Results = FALSE;
return EFI_SUCCESS;
goto EXIT;
}
break;
@@ -894,7 +896,7 @@ ValidateDataFromHiiHandle (
if ((VariableData[((FRAMEWORK_EFI_IFR_NUMERIC *)&RawData[Index])->QuestionId] < ((FRAMEWORK_EFI_IFR_NUMERIC *)&RawData[Index])->Minimum) ||
(VariableData[((FRAMEWORK_EFI_IFR_NUMERIC *)&RawData[Index])->QuestionId] > ((FRAMEWORK_EFI_IFR_NUMERIC *)&RawData[Index])->Maximum)) {
*Results = FALSE;
return EFI_SUCCESS;
goto EXIT;
}
break;
@@ -903,11 +905,12 @@ ValidateDataFromHiiHandle (
Index = RawData[Index + 1] + Index;
}
EXIT:
//
// Free our temporary repository of form data
//
gBS->FreePool (OldData);
gBS->FreePool (VariableData);
FreePool (OldData);
FreePool (VariableData);
return EFI_SUCCESS;
}

2
IntelFrameworkPkg/Library/FrameworkIfrSupportLib/IfrOnTheFly.c
View File

@@ -72,6 +72,8 @@ CreateFormSet (
GetCurrentLanguage (CurrentLanguage);
Status = AddString (*StringBuffer, CurrentLanguage, FormSetTitle, &StringToken);
if (EFI_ERROR (Status)) {
FreePool (FormBuffer);
FreePool (StringBuffer);
return Status;
}

17
IntelFrameworkPkg/Library/FrameworkIfrSupportLib/IfrSupportLib.inf
View File

@@ -1,9 +1,10 @@
#/** @file
# EDK Internal Form Refresentation Support Library Instance.
#
# The library instance provides common library routines help in
# IFR creation on-the-fly, HII variable access, HII database access, multi language supports.
# Copyright (c) 2006 - 2007, Intel Corporation.
# The library instance provides common library routines help in IFR creation on-the-fly,
# HII variable access, HII database access, multi language supports.
#
# Copyright (c) 2006 - 2007, Intel Corporation.
#
# All rights reserved. This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -22,8 +23,7 @@
MODULE_TYPE = DXE_DRIVER
VERSION_STRING = 1.0
LIBRARY_CLASS = FrameworkIfrSupportLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
EDK_RELEASE_VERSION = 0x00020000
EFI_SPECIFICATION_VERSION = 0x00020000
PI_SPECIFICATION_VERSION = 0x00000009
#
# The following information is for reference only and not required by the build tools.
@@ -40,12 +40,10 @@
IfrCommon.c
IfrSupportLibInternal.h
[Packages]
MdePkg/MdePkg.dec
IntelFrameworkPkg/IntelFrameworkPkg.dec
[LibraryClasses]
UefiRuntimeServicesTableLib
UefiBootServicesTableLib
@@ -54,11 +52,8 @@
BaseLib
DebugLib
[Guids]
gEfiGlobalVariableGuid # ALWAYS_CONSUMED
gEfiGlobalVariableGuid # CONSUMED, Variable Name: L"Lan"
[Protocols]
gEfiHiiProtocolGuid # PROTOCOL ALWAYS_CONSUMED