sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdeModulePkg/PciBus: Change PCI_IO_DEVICE.RomSize to UINT32 type

Browse Source 
Per PCI Spec, the option ROM BAR is 32bit so the maximum option ROM
size can be hold by UINT32 type.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
This commit is contained in:
Ray Ni
2019-02-11 13:11:57 +08:00
parent d72d8561fb
commit 1f6785c4b7
5 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h
View File

@ -1,7 +1,7 @@
/** @file /** @file
Header files and data structures needed by PCI Bus module. Header files and data structures needed by PCI Bus module.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -237,7 +237,7 @@ struct _PCI_IO_DEVICE {
// //
// The OptionRom Size // The OptionRom Size
// //
UINT64 RomSize; UINT32 RomSize;
// //
// TRUE if all OpROM (in device or in platform specific position) have been processed // TRUE if all OpROM (in device or in platform specific position) have been processed

6
MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
Supporting functions implementaion for PCI devices management. Supporting functions implementaion for PCI devices management.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2018 Hewlett Packard Enterprise Development LP<BR> (C) Copyright 2018 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
@ -259,7 +259,7 @@ RegisterPciDevice (
); );
if (!EFI_ERROR (Status)) { if (!EFI_ERROR (Status)) {
PciIoDevice->EmbeddedRom = FALSE; PciIoDevice->EmbeddedRom = FALSE;
PciIoDevice->RomSize = PlatformOpRomSize; PciIoDevice->RomSize = (UINT32) PlatformOpRomSize;
PciIoDevice->PciIo.RomSize = PlatformOpRomSize; PciIoDevice->PciIo.RomSize = PlatformOpRomSize;
PciIoDevice->PciIo.RomImage = PlatformOpRomBuffer; PciIoDevice->PciIo.RomImage = PlatformOpRomBuffer;
// //
@ -285,7 +285,7 @@ RegisterPciDevice (
); );
if (!EFI_ERROR (Status)) { if (!EFI_ERROR (Status)) {
PciIoDevice->EmbeddedRom = FALSE; PciIoDevice->EmbeddedRom = FALSE;
PciIoDevice->RomSize = PlatformOpRomSize; PciIoDevice->RomSize = (UINT32) PlatformOpRomSize;
PciIoDevice->PciIo.RomSize = PlatformOpRomSize; PciIoDevice->PciIo.RomSize = PlatformOpRomSize;
PciIoDevice->PciIo.RomImage = PlatformOpRomBuffer; PciIoDevice->PciIo.RomImage = PlatformOpRomBuffer;
// //

8
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
PCI eunmeration implementation on entire PCI bus system for PCI Bus module. PCI eunmeration implementation on entire PCI bus system for PCI Bus module.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
@ -528,15 +528,15 @@ DetermineRootBridgeAttributes (
@return Max size of option rom needed. @return Max size of option rom needed.
**/ **/
UINT64 UINT32
GetMaxOptionRomSize ( GetMaxOptionRomSize (
IN PCI_IO_DEVICE *Bridge IN PCI_IO_DEVICE *Bridge
) )
{ {
LIST_ENTRY *CurrentLink; LIST_ENTRY *CurrentLink;
PCI_IO_DEVICE *Temp; PCI_IO_DEVICE *Temp;
UINT64 MaxOptionRomSize; UINT32 MaxOptionRomSize;
UINT64 TempOptionRomSize; UINT32 TempOptionRomSize;
MaxOptionRomSize = 0; MaxOptionRomSize = 0;

4
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.h
View File

@ -1,7 +1,7 @@
/** @file /** @file
PCI bus enumeration logic function declaration for PCI bus module. PCI bus enumeration logic function declaration for PCI bus module.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -109,7 +109,7 @@ DetermineRootBridgeAttributes (
@return Max size of option rom needed. @return Max size of option rom needed.
**/ **/
UINT64 UINT32
GetMaxOptionRomSize ( GetMaxOptionRomSize (
IN PCI_IO_DEVICE *Bridge IN PCI_IO_DEVICE *Bridge
); );

4
MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
Internal library implementation for PCI Bus module. Internal library implementation for PCI Bus module.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
@ -415,7 +415,7 @@ PciHostBridgeResourceAllocator (
UINT64 PMem32ResStatus; UINT64 PMem32ResStatus;
UINT64 Mem64ResStatus; UINT64 Mem64ResStatus;
UINT64 PMem64ResStatus; UINT64 PMem64ResStatus;
UINT64 MaxOptionRomSize; UINT32 MaxOptionRomSize;
PCI_RESOURCE_NODE *IoBridge; PCI_RESOURCE_NODE *IoBridge;
PCI_RESOURCE_NODE *Mem32Bridge; PCI_RESOURCE_NODE *Mem32Bridge;
PCI_RESOURCE_NODE *PMem32Bridge; PCI_RESOURCE_NODE *PMem32Bridge;