MdeModulePkg/AtaAtapiPassThru: relax PHY detect timeout
The SATA spec mandates that link detection by the PHY completes within 10 ms after receiving a reset signal. However, there is no obligation to uphold this requirement at the driver end as strictly as we do, and as it turns out, some combinations of host and device (e.g., Samsung 850 EVO connected to a LeMaker Cello) are only borderline compliant, which means the device is not detected reliably. So let's allow for a bit of margin, and increase the PHY detect timeout value to 15 ms. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Star Zeng <star.zeng@intel.com>
This commit is contained in:
@@ -2376,8 +2376,7 @@ AhciModeInitialization (
|
||||
AhciOrReg (PciIo, Offset, EFI_AHCI_PORT_CMD_FRE);
|
||||
|
||||
//
|
||||
// Wait no longer than 10 ms to wait the Phy to detect the presence of a device.
|
||||
// It's the requirment from SATA1.0a spec section 5.2.
|
||||
// Wait for the Phy to detect the presence of a device.
|
||||
//
|
||||
PhyDetectDelay = EFI_AHCI_BUS_PHY_DETECT_TIMEOUT;
|
||||
Offset = EFI_AHCI_PORT_START + Port * EFI_AHCI_PORT_REG_WIDTH + EFI_AHCI_PORT_SSTS;
|
||||
|
Reference in New Issue
Block a user