sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

code scrub on Ps2MouseDxe module

Browse Source 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8657 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
eric_tian
2009-06-25 08:27:12 +00:00
parent a1ed88afe6
commit 24a2dd3d08
3 changed files with 57 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
PS2 Mouse Communication Interface. PS2 Mouse Communication Interface.
Copyright (c) 2006 - 2007, Intel Corporation Copyright (c) 2006 - 2009, Intel Corporation
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -892,23 +892,6 @@ WaitOutputFull (
IN EFI_ISA_IO_PROTOCOL *IsaIo, IN EFI_ISA_IO_PROTOCOL *IsaIo,
IN UINTN Timeout IN UINTN Timeout
) )
/**
Routine Description:
GC_TODO: Add function description
Arguments:
IsaIo - GC_TODO: add argument description
Timeout - GC_TODO: add argument description
Returns:
EFI_TIMEOUT - GC_TODO: Add description for return value
EFI_SUCCESS - GC_TODO: Add description for return value
**/
{ {
UINTN Delay; UINTN Delay;
UINT8 Data; UINT8 Data;

73
IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h
View File

@ -75,32 +75,50 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
// //
// Keyboard Controller Status // Keyboard Controller Status
// //
#define KBC_PARE 0x80 // Parity Error ///
#define KBC_TIM 0x40 // General Time Out /// Parity Error
#define KBC_AUXB 0x20 // Output buffer for auxiliary device (PS/2): ///
// 0 - Holds keyboard data #define KBC_PARE 0x80
// 1 - Holds data for auxiliary device ///
// /// General Time Out
#define KBC_KEYL 0x10 // Keyboard lock status: ///
// 0 - keyboard locked #define KBC_TIM 0x40
// 1 - keyboard free ///
// /// Output buffer for auxiliary device (PS/2):
#define KBC_CD 0x08 // Command/Data: /// 0 - Holds keyboard data
// 0 - data byte written via port 60h /// 1 - Holds data for auxiliary device
// 1 - command byte written via port 64h ///
// #define KBC_AUXB 0x20
#define KBC_SYSF 0x04 // System Flag: ///
// 0 - power-on reset /// Keyboard lock status:
// 1 - self-test successful /// 0 - keyboard locked
// /// 1 - keyboard free
#define KBC_INPB 0x02 // Input Buffer Status : ///
// 0 - input buffer empty #define KBC_KEYL 0x10
// 1 - CPU data in input buffer ///
// /// Command/Data:
#define KBC_OUTB 0x01 // Output Buffer Status : /// 0 - data byte written via port 60h
// 0 - output buffer empty /// 1 - command byte written via port 64h
// 1 - keyboard controller data in output buffer ///
// #define KBC_CD 0x08
///
/// System Flag:
/// 0 - power-on reset
/// 1 - self-test successful
///
#define KBC_SYSF 0x04
///
/// Input Buffer Status :
/// 0 - input buffer empty
/// 1 - CPU data in input buffer
///
#define KBC_INPB 0x02
///
/// Output Buffer Status :
/// 0 - output buffer empty
/// 1 - keyboard controller data in output buffer
///
#define KBC_OUTB 0x01
/** /**
Issue self test command via IsaIo interface. Issue self test command via IsaIo interface.
@ -413,4 +431,5 @@ WaitOutputFull (
IN UINTN Timeout IN UINTN Timeout
); );
#endif // _COMMPS2_H_ #endif

20
IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c
View File

@ -1,8 +1,8 @@
/** @file /** @file
PS/2 Mouse driver. Routines that interacts with callers, PS/2 Mouse driver. Routines that interacts with callers,
conforming to EFI driver model conforming to EFI driver model.
Copyright (c) 2006 - 2007, Intel Corporation Copyright (c) 2006 - 2009, Intel Corporation
All rights reserved. This program and the accompanying materials All rights reserved. This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -16,9 +16,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#include "Ps2Mouse.h" #include "Ps2Mouse.h"
#include "CommPs2.h" #include "CommPs2.h"
// ///
// DriverBinding Protocol Instance /// DriverBinding Protocol Instance
// ///
EFI_DRIVER_BINDING_PROTOCOL gPS2MouseDriver = { EFI_DRIVER_BINDING_PROTOCOL gPS2MouseDriver = {
PS2MouseDriverSupported, PS2MouseDriverSupported,
PS2MouseDriverStart, PS2MouseDriverStart,
@ -109,9 +109,9 @@ PS2MouseDriverSupported (
} }
/** /**
Start this driver on ControllerHandle by opening a IsaIo Start this driver on ControllerHandle by opening a IsaIo protocol, creating
protocol, creating PS2_MOUSE_ABSOLUTE_POINTER_DEV device and install gEfiAbsolutePointerProtocolGuid PS2_MOUSE_ABSOLUTE_POINTER_DEV device and install gEfiAbsolutePointerProtocolGuid
finnally. finally.
@param This Protocol instance pointer. @param This Protocol instance pointer.
@param ControllerHandle Handle of device to bind driver to @param ControllerHandle Handle of device to bind driver to
@ -377,7 +377,7 @@ ErrorExit:
} }
if (MouseDev != NULL) { if (MouseDev != NULL) {
gBS->FreePool (MouseDev); FreePool (MouseDev);
} }
gBS->CloseProtocol ( gBS->CloseProtocol (
@ -480,7 +480,7 @@ PS2MouseDriverStop (
gBS->CloseEvent (MouseDev->SimplePointerProtocol.WaitForInput); gBS->CloseEvent (MouseDev->SimplePointerProtocol.WaitForInput);
FreeUnicodeStringTable (MouseDev->ControllerNameTable); FreeUnicodeStringTable (MouseDev->ControllerNameTable);
gBS->FreePool (MouseDev); FreePool (MouseDev);
gBS->CloseProtocol ( gBS->CloseProtocol (
Controller, Controller,