sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdePkg/DevicePathFromText: Fix byte orders of iSCSI.Lun

Browse Source 
Per UEFI spec, iSCSI.Lun is a 8-byte array with byte #0 in the left.
It means "0102030405060708" should be converted to:
    UINT8[8] = {01, 02, 03, 04, 05, 06, 07, 08}
or  UINT64 = {0807060504030201}

Today's implementation wrongly uses the reversed order.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jie Lin <jie.lin@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
(cherry picked from commit d0196be1e3)
This commit is contained in:
Ruiyu Ni
2018-03-02 19:50:30 +08:00
parent c5b32c02a4
commit 270bc06e99
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c
View File

@@ -2542,6 +2542,7 @@ DevPathFromTextiSCSI (
CHAR16 *ProtocolStr; CHAR16 *ProtocolStr;
CHAR8 *AsciiStr; CHAR8 *AsciiStr;
ISCSI_DEVICE_PATH_WITH_NAME *ISCSIDevPath; ISCSI_DEVICE_PATH_WITH_NAME *ISCSIDevPath;
UINT64 Lun;
NameStr = GetNextParamStr (&TextDeviceNode); NameStr = GetNextParamStr (&TextDeviceNode);
PortalGroupStr = GetNextParamStr (&TextDeviceNode); PortalGroupStr = GetNextParamStr (&TextDeviceNode);
@@ -2560,7 +2561,8 @@ DevPathFromTextiSCSI (
StrToAscii (NameStr, &AsciiStr); StrToAscii (NameStr, &AsciiStr);
ISCSIDevPath->TargetPortalGroupTag = (UINT16) Strtoi (PortalGroupStr); ISCSIDevPath->TargetPortalGroupTag = (UINT16) Strtoi (PortalGroupStr);
Strtoi64 (LunStr, &ISCSIDevPath->Lun); Strtoi64 (LunStr, &Lun);
WriteUnaligned64 ((UINT64 *) &ISCSIDevPath->Lun, SwapBytes64 (Lun));
Options = 0x0000; Options = 0x0000;
if (StrCmp (HeaderDigestStr, L"CRC32C") == 0) { if (StrCmp (HeaderDigestStr, L"CRC32C") == 0) {