From 2a0d4a2641a706d6b964dea0c95b1e0362194f57 Mon Sep 17 00:00:00 2001 From: "Lee, Chun-Yi" Date: Sun, 4 Feb 2024 17:29:14 +0800 Subject: [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again In case PcdFirmwareReleaseDateString is not set use a valid date as fallback. But the default valid date can _NOT_ pass the Microsoft SVVP test "Check SMBIOS Table Specific Requirements". The test emitted the error message: BIOS Release Date string is unexpected length: 8. This string must be in MM/DD/YYYY format. No other format is allowed and no additional information may be included. See field description in the SMBIOS specification. Base on SMBIOS spec v3.7.0: 08h 2.0+ BIOS Release Date BYTE STRING String number of the BIOS release date. The date string, if supplied, is in either mm/dd/yy or mm/dd/yyyy format. If the year portion of the string is two digits, the year is assumed to be 19yy. NOTE: The mm/dd/yyyy format is required for SMBIOS version 2.3 and later. So, let's tweek the fallback release date again. Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327] Signed-off-by: "Lee, Chun-Yi" Message-Id: <20240204092914.29813-1-jlee@suse.com> Reviewed-by: Laszlo Ersek Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Pawel Polawski Cc: Oliver Steffen Cc: Ard Biesheuvel Cc: Ruifeng Gao Cc: "Lee, Chun-Yi" [lersek@redhat.com: Turn the CC's from the list posting to commit message body tags, for placating "PatchCheck.py". Also work the "ruifeng.gao@intel.com" email address into a format that "PatchCheck.py" accepts.] --- OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c index 0ca3776045..e929da6b81 100644 --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -160,7 +160,7 @@ InstallAllStructures ( DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); DateLen = StrLen (DateStr); if (DateLen < 3) { - DateStr = L"2/2/2022"; + DateStr = L"02/02/2022"; DateLen = StrLen (DateStr); }