sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BaseTools: Remove the redundant __FLEXIBLE_SIZE from PcdValueInit.c

Browse Source 
For the multiple SKU case, basetools generates multiple redundant
__FLEXIBLE_SIZE statement that is from the same line in dsc file.

This behavior causes the generated PcdValueInit.c file to have huge size,
and the compilation time is very long.

This patch is going to fix this issue.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Reviewed-by: Yuwei Chen <yuwei.chen@intel.com>
This commit is contained in:
Bob Feng
2022-03-15 20:16:54 +08:00
committed by mergify[bot]
parent bf9230a9f3
commit 3115377bf0
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
BaseTools/Source/Python/Workspace/DscBuildData.py
View File

@ -1876,6 +1876,7 @@ class DscBuildData(PlatformBuildClassObject):
while '[' in FieldName and not Pcd.IsArray(): while '[' in FieldName and not Pcd.IsArray():
FieldName = FieldName.rsplit('[', 1)[0] FieldName = FieldName.rsplit('[', 1)[0]
CApp = CApp + ' __FLEXIBLE_SIZE(*Size, %s, %s, %d); // From %s Line %d Value %s\n' % (Pcd.DatumType, FieldName.strip("."), Array_Index + 1, FieldList[FieldName_ori][1], FieldList[FieldName_ori][2], FieldList[FieldName_ori][0]) CApp = CApp + ' __FLEXIBLE_SIZE(*Size, %s, %s, %d); // From %s Line %d Value %s\n' % (Pcd.DatumType, FieldName.strip("."), Array_Index + 1, FieldList[FieldName_ori][1], FieldList[FieldName_ori][2], FieldList[FieldName_ori][0])
flexisbale_size_statement_cache = set()
for skuname in Pcd.SkuOverrideValues: for skuname in Pcd.SkuOverrideValues:
if skuname == TAB_COMMON: if skuname == TAB_COMMON:
continue continue
@ -1888,6 +1889,10 @@ class DscBuildData(PlatformBuildClassObject):
if not FieldList: if not FieldList:
continue continue
for FieldName in FieldList: for FieldName in FieldList:
fieldinfo = tuple(FieldList[FieldName])
if fieldinfo in flexisbale_size_statement_cache:
continue
flexisbale_size_statement_cache.add(fieldinfo)
FieldName = "." + FieldName FieldName = "." + FieldName
IsArray = _IsFieldValueAnArray(FieldList[FieldName.strip(".")][0]) IsArray = _IsFieldValueAnArray(FieldList[FieldName.strip(".")][0])
if IsArray and not (FieldList[FieldName.strip(".")][0].startswith('{GUID') and FieldList[FieldName.strip(".")][0].endswith('}')): if IsArray and not (FieldList[FieldName.strip(".")][0].startswith('{GUID') and FieldList[FieldName.strip(".")][0].endswith('}')):