From 354a75f9ed0d2f37ace0614135e08e6a8b83e174 Mon Sep 17 00:00:00 2001 From: "Alcantara, Paulo" Date: Tue, 6 Jun 2017 08:33:36 +0800 Subject: [PATCH] MdePkg/Ftp4: Fix wrong function pointer declaration EFI_FTP4_DATA_CALLBACK is a function pointer and defined as follows: > typedef > EFI_STATUS > (EFIAPI *EFI_FTP4_DATA_CALLBACK)( > IN EFI_FTP4_PROTOCOL *This, > IN EFI_FTP4_COMMAND_TOKEN *Token > ); And EFI_FTP4_COMMAND_TOKEN structure declared it as: > EFI_FTP4_DATA_CALLBACK *DataCallback Which ended up being a pointer to function pointer and clearly wrong. This patch fixes it by removing the misleading '*' from declaration. It's also fixed in new UEFI 2.7 spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara Reviewed-by: Fu Siyuan --- MdePkg/Include/Protocol/Ftp4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/Ftp4.h b/MdePkg/Include/Protocol/Ftp4.h index 1c4a5db925..536b3f3635 100644 --- a/MdePkg/Include/Protocol/Ftp4.h +++ b/MdePkg/Include/Protocol/Ftp4.h @@ -204,7 +204,7 @@ struct _EFI_FTP4_COMMAND_TOKEN { /// DataBufferSize, again. If there is no data remained, /// DataBufferSize should be set to 0. /// - EFI_FTP4_DATA_CALLBACK *DataCallback; + EFI_FTP4_DATA_CALLBACK DataCallback; /// /// Pointer to the parameter for DataCallback. ///