If DataSize or VariableNameSize is near MAX_ADDRESS, this can cause the computed PayLoadSize to overflow to a small value and pass the check in InitCommunicateBuffer(). To protect against this vulnerability, check DataSize and VariableNameSize to make sure PayloadSize doesn't overflow.
Signed-off-by: Star Zeng <star.zeng@intel.com> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com> git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14252 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
@ -2755,6 +2755,11 @@ VariableCommonInitialize (
|
||||
}
|
||||
ASSERT(VariableStoreHeader->Size == VariableStoreLength);
|
||||
|
||||
//
|
||||
// The max variable or hardware error variable size should be < variable store size.
|
||||
//
|
||||
ASSERT(MAX (PcdGet32 (PcdMaxVariableSize), PcdGet32 (PcdMaxHardwareErrorVariableSize)) < VariableStoreLength);
|
||||
|
||||
//
|
||||
// Parse non-volatile variable data and get last variable offset.
|
||||
//
|
||||
|
Reference in New Issue
Block a user