MdeModulePkg: Use IsZeroGuid API for zero GUID checking
Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Feng Tian <feng.tian@intel.com> Cc: Star Zeng <star.zeng@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu <hao.a.wu@intel.com> Reviewed-by: Feng Tian <feng.tian@Intel.com>
This commit is contained in:
@@ -2829,7 +2829,7 @@ EvaluateExpression (
|
||||
if (StrPtr != NULL) {
|
||||
FreePool (StrPtr);
|
||||
}
|
||||
} else if (CompareGuid (&OpCode->Guid, &gZeroGuid) != 0) {
|
||||
} else if (IsZeroGuid (&OpCode->Guid)) {
|
||||
if (!GetQuestionValueFromForm(NULL, FormSet->HiiHandle, &OpCode->Guid, Value->Value.u16, &QuestionVal)){
|
||||
Value->Type = EFI_IFR_TYPE_UNDEFINED;
|
||||
break;
|
||||
|
@@ -358,7 +358,7 @@ InitializeDisplayStatement (
|
||||
//
|
||||
// Create the refresh event process function.
|
||||
//
|
||||
if (!CompareGuid (&Statement->RefreshGuid, &gZeroGuid)) {
|
||||
if (!IsZeroGuid (&Statement->RefreshGuid)) {
|
||||
CreateRefreshEventForStatement (Statement);
|
||||
}
|
||||
|
||||
@@ -373,7 +373,7 @@ InitializeDisplayStatement (
|
||||
// Create the refresh guid hook event.
|
||||
// If the statement in this form has refresh event or refresh interval, browser will create this event for display engine.
|
||||
//
|
||||
if ((!CompareGuid (&Statement->RefreshGuid, &gZeroGuid)) || (Statement->RefreshInterval != 0)) {
|
||||
if ((!IsZeroGuid (&Statement->RefreshGuid)) || (Statement->RefreshInterval != 0)) {
|
||||
gDisplayFormData.FormRefreshEvent = mValueChangedEvent;
|
||||
}
|
||||
|
||||
@@ -628,7 +628,7 @@ AddStatementToDisplayForm (
|
||||
//
|
||||
// Create the refresh event process function for Form.
|
||||
//
|
||||
if (!CompareGuid (&gCurrentSelection->Form->RefreshGuid, &gZeroGuid)) {
|
||||
if (!IsZeroGuid (&gCurrentSelection->Form->RefreshGuid)) {
|
||||
CreateRefreshEventForForm (gCurrentSelection->Form);
|
||||
if (gDisplayFormData.FormRefreshEvent == NULL) {
|
||||
gDisplayFormData.FormRefreshEvent = mValueChangedEvent;
|
||||
@@ -1410,7 +1410,7 @@ ProcessGotoOpCode (
|
||||
CopyMem (&Selection->FormSetGuid,&Statement->HiiValue.Value.ref.FormSetGuid, sizeof (EFI_GUID));
|
||||
Selection->FormId = Statement->HiiValue.Value.ref.FormId;
|
||||
Selection->QuestionId = Statement->HiiValue.Value.ref.QuestionId;
|
||||
} else if (!CompareGuid (&Statement->HiiValue.Value.ref.FormSetGuid, &gZeroGuid)) {
|
||||
} else if (!IsZeroGuid (&Statement->HiiValue.Value.ref.FormSetGuid)) {
|
||||
if (Selection->Form->ModalForm) {
|
||||
return Status;
|
||||
}
|
||||
|
@@ -181,7 +181,7 @@ UiFindMenuList (
|
||||
// Find the same FromSet.
|
||||
//
|
||||
if (MenuList->HiiHandle == HiiHandle) {
|
||||
if (CompareGuid (&MenuList->FormSetGuid, &gZeroGuid)) {
|
||||
if (IsZeroGuid (&MenuList->FormSetGuid)) {
|
||||
//
|
||||
// FormSetGuid is not specified.
|
||||
//
|
||||
@@ -5689,7 +5689,7 @@ GetIfrBinaryData (
|
||||
//
|
||||
// Try to compare against formset GUID
|
||||
//
|
||||
if (CompareGuid (FormSetGuid, &gZeroGuid) ||
|
||||
if (IsZeroGuid (FormSetGuid) ||
|
||||
CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData + sizeof (EFI_IFR_OP_HEADER)))) {
|
||||
break;
|
||||
}
|
||||
|
Reference in New Issue
Block a user