sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ShellPkg/UefiShellLib: Use BaseLib api CharToUpper

Browse Source 
Substitute InternalShellCharToUpper with CharToUpper which is a public
function with the same effect.
Remove the implement of InternalShellCharToUpper.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
This commit is contained in:
Shenglei Zhang
2019-01-30 16:34:57 +08:00
committed by Liming Gao
parent 3eaf5e8cf6
commit 3d086fed73
1 changed files with 3 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
ShellPkg/Library/UefiShellLib/UefiShellLib.c
View File

@ -3,7 +3,7 @@
(C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
Copyright 2016-2018 Dell Technologies.<BR> Copyright 2016-2018 Dell Technologies.<BR>
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -3740,33 +3740,6 @@ ShellFileExists(
return (EFI_SUCCESS); return (EFI_SUCCESS);
} }
/**
Convert a Unicode character to upper case only if
it maps to a valid small-case ASCII character.
This internal function only deal with Unicode character
which maps to a valid small-case ASCII character, i.e.
L'a' to L'z'. For other Unicode character, the input character
is returned directly.
@param Char The character to convert.
@retval LowerCharacter If the Char is with range L'a' to L'z'.
@retval Unchanged Otherwise.
**/
CHAR16
InternalShellCharToUpper (
IN CHAR16 Char
)
{
if (Char >= L'a' && Char <= L'z') {
return (CHAR16) (Char - (L'a' - L'A'));
}
return Char;
}
/** /**
Convert a Unicode character to numerical value. Convert a Unicode character to numerical value.
@ -3789,7 +3762,7 @@ InternalShellHexCharToUintn (
return Char - L'0'; return Char - L'0';
} }
return (10 + InternalShellCharToUpper (Char) - L'A'); return (10 + CharToUpper (Char) - L'A');
} }
/** /**
@ -3849,7 +3822,7 @@ InternalShellStrHexToUint64 (
String++; String++;
} }
if (InternalShellCharToUpper (*String) == L'X') { if (CharToUpper (*String) == L'X') {
if (*(String - 1) != L'0') { if (*(String - 1) != L'0') {
return 0; return 0;
} }