sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix comparisons of enumerated types which may cause warnings for some compilers.

Browse Source 
Signed-off-by: Sun Rui <rui.sun@intel.com>
Reviewed-by: Gao Liming <liming.gao@intel.com>


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13686 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
rsun3
2012-08-28 06:48:28 +00:00
parent 055c829c42
commit 3d78c020d2
24 changed files with 92 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
PcAtChipsetPkg/8259InterruptControllerDxe/8259.c
View File

@@ -1,7 +1,7 @@
/** @file
This contains the installation function for the driver.
Copyright (c) 2005 - 2011, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2005 - 2012, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -413,7 +413,7 @@ Interrupt8259GetVector (
OUT UINT8 *Vector
)
{
if (Irq < Efi8259Irq0 || Irq > Efi8259Irq15) {
if ((UINT32)Irq > Efi8259Irq15) {
return EFI_INVALID_PARAMETER;
}
@@ -445,7 +445,7 @@ Interrupt8259EnableIrq (
IN BOOLEAN LevelTriggered
)
{
if (Irq < Efi8259Irq0 || Irq > Efi8259Irq15) {
if ((UINT32)Irq > Efi8259Irq15) {
return EFI_INVALID_PARAMETER;
}
@@ -478,7 +478,7 @@ Interrupt8259DisableIrq (
IN EFI_8259_IRQ Irq
)
{
if (Irq < Efi8259Irq0 || Irq > Efi8259Irq15) {
if ((UINT32)Irq > Efi8259Irq15) {
return EFI_INVALID_PARAMETER;
}
@@ -555,7 +555,7 @@ Interrupt8259EndOfInterrupt (
IN EFI_8259_IRQ Irq
)
{
if (Irq < Efi8259Irq0 || Irq > Efi8259Irq15) {
if ((UINT32)Irq > Efi8259Irq15) {
return EFI_INVALID_PARAMETER;
}

4
PcAtChipsetPkg/PciHostBridgeDxe/PciHostBridge.c
View File

@@ -1,7 +1,7 @@
/** @file
Provides the basic interfaces to abstract a PCI Host Bridge Resource Allocation
Copyright (c) 2008 - 2010, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are
licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -1180,7 +1180,7 @@ PreprocessController (
return EFI_INVALID_PARAMETER;
}
if (Phase < EfiPciBeforeChildBusEnumeration || Phase > EfiPciBeforeResourceCollection) {
if ((UINT32)Phase > EfiPciBeforeResourceCollection) {
return EFI_INVALID_PARAMETER;
}

12
PcAtChipsetPkg/PciHostBridgeDxe/PciRootBridgeIo.c
View File

@@ -1,7 +1,7 @@
/** @file
PCI Root Bridge Io Protocol implementation
Copyright (c) 2008 - 2010, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are
licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -770,7 +770,7 @@ RootBridgeIoCheckParameter (
//
// Check to see if Width is in the valid range
//
if (Width < EfiPciWidthUint8 || Width >= EfiPciWidthMaximum) {
if ((UINT32)Width >= EfiPciWidthMaximum) {
return EFI_INVALID_PARAMETER;
}
@@ -1233,7 +1233,7 @@ RootBridgeIoPollMem (
return EFI_INVALID_PARAMETER;
}
if (Width < 0 || Width > EfiPciWidthUint64) {
if ((UINT32)Width > EfiPciWidthUint64) {
return EFI_INVALID_PARAMETER;
}
@@ -1340,7 +1340,7 @@ RootBridgeIoPollIo (
return EFI_INVALID_PARAMETER;
}
if (Width < 0 || Width > EfiPciWidthUint64) {
if ((UINT32)Width > EfiPciWidthUint64) {
return EFI_INVALID_PARAMETER;
}
@@ -1561,7 +1561,7 @@ RootBridgeIoCopyMem (
UINTN Index;
UINT64 Result;
if (Width < 0 || Width > EfiPciWidthUint64) {
if ((UINT32)Width > EfiPciWidthUint64) {
return EFI_INVALID_PARAMETER;
}
@@ -1735,7 +1735,7 @@ RootBridgeIoMap (
//
// Make sure that Operation is valid
//
if (Operation < 0 || Operation >= EfiPciOperationMaximum) {
if ((UINT32)Operation >= EfiPciOperationMaximum) {
return EFI_INVALID_PARAMETER;
}