sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NetworkPkg: Refine UintnToAscDecWithFormat functions logic

Browse Source 
This commit refines the logic for HttpBootUintnToAscDecWithFormat and
PxeBcUintnToAscDecWithFormat. It avoids using the decrement operator '--'
for array index to prevent possible mis-reports by static code checkers.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
This commit is contained in:
Hao Wu
2016-11-15 16:25:22 +08:00
parent 81a1084340
commit 413535bb33
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
NetworkPkg/HttpBootDxe/HttpBootSupport.c
View File

@ -86,11 +86,10 @@ HttpBootUintnToAscDecWithFormat (
{ {
UINTN Remainder; UINTN Remainder;
while (Length > 0) { for (; Length > 0; Length--) {
Length--;
Remainder = Number % 10; Remainder = Number % 10;
Number /= 10; Number /= 10;
Buffer[Length] = (UINT8) ('0' + Remainder); Buffer[Length - 1] = (UINT8) ('0' + Remainder);
} }
} }

5
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
View File

@ -1383,11 +1383,10 @@ PxeBcUintnToAscDecWithFormat (
{ {
UINTN Remainder; UINTN Remainder;
while (Length > 0) { for (; Length > 0; Length--) {
Length--;
Remainder = Number % 10; Remainder = Number % 10;
Number /= 10; Number /= 10;
Buffer[Length] = (UINT8) ('0' + Remainder); Buffer[Length - 1] = (UINT8) ('0' + Remainder);
} }
} }