MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948 XhciDxe uses the timer functionality provided by the boot services table to detect timeout conditions. This breaks the driver's ExitBootServices call back, as CoreExitBootServices halts the timer before signaling the ExitBootServices event. If the host controller fails to halt in the call back, the timeout condition will never occur and the boot gets stuck in an indefinite spin loop. Use the free running timer provided by TimerLib to calculate timeouts, avoiding the potential hang. Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Patrick Henz <patrick.henz@hpe.com> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
This commit is contained in:
committed by
mergify[bot]
parent
8b2e6b90b8
commit
43dcf453fc
@@ -2,6 +2,7 @@
|
||||
|
||||
XHCI transfer scheduling routines.
|
||||
|
||||
(C) Copyright 2023 Hewlett Packard Enterprise Development LP<BR>
|
||||
Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>
|
||||
Copyright (c) Microsoft Corporation.<BR>
|
||||
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.<BR>
|
||||
@@ -1276,15 +1277,14 @@ EXIT:
|
||||
/**
|
||||
Execute the transfer by polling the URB. This is a synchronous operation.
|
||||
|
||||
@param Xhc The XHCI Instance.
|
||||
@param CmdTransfer The executed URB is for cmd transfer or not.
|
||||
@param Urb The URB to execute.
|
||||
@param Timeout The time to wait before abort, in millisecond.
|
||||
@param Xhc The XHCI Instance.
|
||||
@param CmdTransfer The executed URB is for cmd transfer or not.
|
||||
@param Urb The URB to execute.
|
||||
@param Timeout The time to wait before abort, in millisecond.
|
||||
|
||||
@return EFI_DEVICE_ERROR The transfer failed due to transfer error.
|
||||
@return EFI_TIMEOUT The transfer failed due to time out.
|
||||
@return EFI_SUCCESS The transfer finished OK.
|
||||
@retval EFI_OUT_OF_RESOURCES Memory for the timer event could not be allocated.
|
||||
@return EFI_DEVICE_ERROR The transfer failed due to transfer error.
|
||||
@return EFI_TIMEOUT The transfer failed due to time out.
|
||||
@return EFI_SUCCESS The transfer finished OK.
|
||||
|
||||
**/
|
||||
EFI_STATUS
|
||||
@@ -1299,12 +1299,14 @@ XhcExecTransfer (
|
||||
UINT8 SlotId;
|
||||
UINT8 Dci;
|
||||
BOOLEAN Finished;
|
||||
EFI_EVENT TimeoutEvent;
|
||||
UINT64 TimeoutTicks;
|
||||
UINT64 ElapsedTicks;
|
||||
UINT64 TicksDelta;
|
||||
UINT64 CurrentTick;
|
||||
BOOLEAN IndefiniteTimeout;
|
||||
|
||||
Status = EFI_SUCCESS;
|
||||
Finished = FALSE;
|
||||
TimeoutEvent = NULL;
|
||||
IndefiniteTimeout = FALSE;
|
||||
|
||||
if (CmdTransfer) {
|
||||
@@ -1322,34 +1324,18 @@ XhcExecTransfer (
|
||||
|
||||
if (Timeout == 0) {
|
||||
IndefiniteTimeout = TRUE;
|
||||
goto RINGDOORBELL;
|
||||
}
|
||||
|
||||
Status = gBS->CreateEvent (
|
||||
EVT_TIMER,
|
||||
TPL_CALLBACK,
|
||||
NULL,
|
||||
NULL,
|
||||
&TimeoutEvent
|
||||
);
|
||||
|
||||
if (EFI_ERROR (Status)) {
|
||||
goto DONE;
|
||||
}
|
||||
|
||||
Status = gBS->SetTimer (
|
||||
TimeoutEvent,
|
||||
TimerRelative,
|
||||
EFI_TIMER_PERIOD_MILLISECONDS (Timeout)
|
||||
);
|
||||
|
||||
if (EFI_ERROR (Status)) {
|
||||
goto DONE;
|
||||
}
|
||||
|
||||
RINGDOORBELL:
|
||||
XhcRingDoorBell (Xhc, SlotId, Dci);
|
||||
|
||||
TimeoutTicks = XhcConvertTimeToTicks (
|
||||
XHC_MICROSECOND_TO_NANOSECOND (
|
||||
Timeout * XHC_1_MILLISECOND
|
||||
)
|
||||
);
|
||||
ElapsedTicks = 0;
|
||||
CurrentTick = GetPerformanceCounter ();
|
||||
|
||||
do {
|
||||
Finished = XhcCheckUrbResult (Xhc, Urb);
|
||||
if (Finished) {
|
||||
@@ -1357,22 +1343,22 @@ RINGDOORBELL:
|
||||
}
|
||||
|
||||
gBS->Stall (XHC_1_MICROSECOND);
|
||||
} while (IndefiniteTimeout || EFI_ERROR (gBS->CheckEvent (TimeoutEvent)));
|
||||
TicksDelta = XhcGetElapsedTicks (&CurrentTick);
|
||||
// Ensure that ElapsedTicks is always incremented to avoid indefinite hangs
|
||||
if (TicksDelta == 0) {
|
||||
TicksDelta = XhcConvertTimeToTicks (XHC_MICROSECOND_TO_NANOSECOND (XHC_1_MICROSECOND));
|
||||
}
|
||||
|
||||
DONE:
|
||||
if (EFI_ERROR (Status)) {
|
||||
Urb->Result = EFI_USB_ERR_NOTEXECUTE;
|
||||
} else if (!Finished) {
|
||||
ElapsedTicks += TicksDelta;
|
||||
} while (IndefiniteTimeout || ElapsedTicks < TimeoutTicks);
|
||||
|
||||
if (!Finished) {
|
||||
Urb->Result = EFI_USB_ERR_TIMEOUT;
|
||||
Status = EFI_TIMEOUT;
|
||||
} else if (Urb->Result != EFI_USB_NOERROR) {
|
||||
Status = EFI_DEVICE_ERROR;
|
||||
}
|
||||
|
||||
if (TimeoutEvent != NULL) {
|
||||
gBS->CloseEvent (TimeoutEvent);
|
||||
}
|
||||
|
||||
return Status;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user