NetworkPkg/HttpDxe: Destroy the TLS instance when cleaning up the HTTP child
During clean up the HTTP child, all resources used by it should be cleaned. But currently, TLS instance is not destroyed. This patch is to fix this issue. Cc: Ye Ting <ting.ye@intel.com> Cc: Fu Siyuan <siyuan.fu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
This commit is contained in:
@@ -140,6 +140,7 @@ IsHttpsUrl (
|
||||
Creates a Tls child handle, open EFI_TLS_PROTOCOL and EFI_TLS_CONFIGURATION_PROTOCOL.
|
||||
|
||||
@param[in] ImageHandle The firmware allocated handle for the UEFI image.
|
||||
@param[out] TlsSb Pointer to the TLS SERVICE_BINDING_PROTOCOL.
|
||||
@param[out] TlsProto Pointer to the EFI_TLS_PROTOCOL instance.
|
||||
@param[out] TlsConfiguration Pointer to the EFI_TLS_CONFIGURATION_PROTOCOL instance.
|
||||
|
||||
@@ -150,15 +151,14 @@ EFI_HANDLE
|
||||
EFIAPI
|
||||
TlsCreateChild (
|
||||
IN EFI_HANDLE ImageHandle,
|
||||
OUT EFI_SERVICE_BINDING_PROTOCOL **TlsSb,
|
||||
OUT EFI_TLS_PROTOCOL **TlsProto,
|
||||
OUT EFI_TLS_CONFIGURATION_PROTOCOL **TlsConfiguration
|
||||
)
|
||||
{
|
||||
EFI_STATUS Status;
|
||||
EFI_SERVICE_BINDING_PROTOCOL *TlsSb;
|
||||
EFI_HANDLE TlsChildHandle;
|
||||
|
||||
TlsSb = NULL;
|
||||
TlsChildHandle = 0;
|
||||
|
||||
//
|
||||
@@ -167,13 +167,13 @@ TlsCreateChild (
|
||||
gBS->LocateProtocol (
|
||||
&gEfiTlsServiceBindingProtocolGuid,
|
||||
NULL,
|
||||
(VOID **) &TlsSb
|
||||
(VOID **) TlsSb
|
||||
);
|
||||
if (TlsSb == NULL) {
|
||||
if (*TlsSb == NULL) {
|
||||
return NULL;
|
||||
}
|
||||
|
||||
Status = TlsSb->CreateChild (TlsSb, &TlsChildHandle);
|
||||
Status = (*TlsSb)->CreateChild (*TlsSb, &TlsChildHandle);
|
||||
if (EFI_ERROR (Status)) {
|
||||
return NULL;
|
||||
}
|
||||
@@ -187,7 +187,7 @@ TlsCreateChild (
|
||||
EFI_OPEN_PROTOCOL_GET_PROTOCOL
|
||||
);
|
||||
if (EFI_ERROR (Status)) {
|
||||
TlsSb->DestroyChild (TlsSb, TlsChildHandle);
|
||||
(*TlsSb)->DestroyChild (*TlsSb, TlsChildHandle);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
@@ -200,7 +200,7 @@ TlsCreateChild (
|
||||
EFI_OPEN_PROTOCOL_GET_PROTOCOL
|
||||
);
|
||||
if (EFI_ERROR (Status)) {
|
||||
TlsSb->DestroyChild (TlsSb, TlsChildHandle);
|
||||
(*TlsSb)->DestroyChild (*TlsSb, TlsChildHandle);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user