sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2.

Browse Source 
https://bugzilla.tianocore.org/show_bug.cgi?id=2515

Change the FmpDevicePkg to match the ECC check rule

Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
GuoMinJ
2020-02-13 16:33:46 +08:00
committed by mergify[bot]
parent 5b45b44e6f
commit 466b877f43
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
FmpDevicePkg/FmpDxe/Dependency.c
View File

@@ -163,8 +163,8 @@ Push (
/** /**
Pop an element from the stack. Pop an element from the stack.
@param[in] Value Element to pop. @param[out] Element Element to pop.
@param[in] Type Type of element. @param[in] Type Type of element.
@retval EFI_SUCCESS The value was popped onto the stack. @retval EFI_SUCCESS The value was popped onto the stack.
@retval EFI_ACCESS_DENIED The pop operation underflowed the stack. @retval EFI_ACCESS_DENIED The pop operation underflowed the stack.

2
FmpDevicePkg/FmpDxe/Dependency.h
View File

@@ -56,7 +56,7 @@ EvaluateImageDependencies (
IN CONST EFI_GUID ImageTypeId, IN CONST EFI_GUID ImageTypeId,
IN CONST UINT32 Version, IN CONST UINT32 Version,
IN CONST EFI_FIRMWARE_IMAGE_DEP *Dependencies, IN CONST EFI_FIRMWARE_IMAGE_DEP *Dependencies,
IN CONST UINT32 DependenciesSize, IN CONST UINT32 DepexSize,
OUT BOOLEAN *IsSatisfied OUT BOOLEAN *IsSatisfied
); );

2
FmpDevicePkg/FmpDxe/FmpDxe.c
View File

@@ -413,7 +413,7 @@ PopulateDescriptor (
} }
if (!EFI_ERROR (Status) && Image != NULL) { if (!EFI_ERROR (Status) && Image != NULL) {
IsDepexValid = ValidateImageDepex ((EFI_FIRMWARE_IMAGE_DEP *) Image, ImageSize, &DepexSize); IsDepexValid = ValidateImageDepex ((EFI_FIRMWARE_IMAGE_DEP *) Image, ImageSize, &DepexSize);
if (IsDepexValid == TRUE) { if (IsDepexValid) {
Private->Descriptor.Dependencies = AllocatePool (DepexSize); Private->Descriptor.Dependencies = AllocatePool (DepexSize);
if (Private->Descriptor.Dependencies != NULL) { if (Private->Descriptor.Dependencies != NULL) {
CopyMem (Private->Descriptor.Dependencies->Dependencies, Image, DepexSize); CopyMem (Private->Descriptor.Dependencies->Dependencies, Image, DepexSize);