sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdeModulePkg/DisplayEngine: Fix memory leak issues in DisplayEngine

Browse Source 
The following codes are useless and cause memory leak issues.
So now remove them.

Cc: Cecil Sheng <cecil.sheng@hpe.com>
Cc: Qiu Shumin <shumin.qiu@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
This commit is contained in:
Dandan Bi
2016-05-19 14:17:34 +08:00
committed by Star Zeng
parent e4979beee9
commit 4b7345a7dd
2 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c
View File

@ -1,7 +1,7 @@
/** @file /** @file
Implementation for handling user input from the User Interfaces. Implementation for handling user input from the User Interfaces.
Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR> Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -1299,9 +1299,6 @@ GetSelectionInputPopUp (
ShowDownArrow = FALSE; ShowDownArrow = FALSE;
ShowUpArrow = FALSE; ShowUpArrow = FALSE;
StringPtr = AllocateZeroPool ((gOptionBlockWidth + 1) * 2);
ASSERT (StringPtr);
ZeroMem (&HiiValue, sizeof (EFI_HII_VALUE)); ZeroMem (&HiiValue, sizeof (EFI_HII_VALUE));
Question = MenuOption->ThisTag; Question = MenuOption->ThisTag;

12
MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c
View File

@ -2,7 +2,7 @@
Implementation for handling the User Interface option processing. Implementation for handling the User Interface option processing.
Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR> Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -885,18 +885,8 @@ PasswordProcess (
gUserInput->InputValue.BufferLen = Question->CurrentValue.BufferLen; gUserInput->InputValue.BufferLen = Question->CurrentValue.BufferLen;
gUserInput->InputValue.Type = Question->CurrentValue.Type; gUserInput->InputValue.Type = Question->CurrentValue.Type;
gUserInput->InputValue.Value.string = HiiSetString(gFormData->HiiHandle, gUserInput->InputValue.Value.string, StringPtr, NULL); gUserInput->InputValue.Value.string = HiiSetString(gFormData->HiiHandle, gUserInput->InputValue.Value.string, StringPtr, NULL);
FreePool (StringPtr);
Status = EFI_SUCCESS; Status = EFI_SUCCESS;
if (EFI_ERROR (Status)) {
//
// Reset state machine for password
//
Question->PasswordCheck (gFormData, Question, NULL);
}
return Status;
} else { } else {
// //
// Reset state machine for password // Reset state machine for password