PrmPkg: Add initial PrmSsdtInstallDxe module

Adds a new module that installs a PRM SSDT.

Note: A library class would allow a high degree of flexibility for
platforms that choose:
  1. To not install a PRM SSDT at all (using a NULL library instance)
  2. To install a specific PRM SSDT implementation

However, it is implemented as a driver since build tools are not
linking ACPI tables to drivers from linked library classes.

Cc: Andrew Fish <afish@apple.com>
Cc: Kang Gao <kang.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: Liu Yun <yun.y.liu@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
Acked-by: Liming Gao <gaoliming@byosoft.com.cn>
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com>
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>

PrmPkg/PrmLoaderDxe/Prm.asl

@@ -1,87 +0,0 @@
-/** @file
-  The definition block in ACPI table for PRM Operation Region
-
-  Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
-  SPDX-License-Identifier: BSD-2-Clause-Patent
-**/
-
-DefinitionBlock (
-    "Prm.aml",
-    "SSDT",
-    0x01,
-    "OEMID",
-    "PRMOPREG",
-    0x3000
-    )
-{
-    Scope (\_SB)
-    {
-        //
-        // PRM Bridge Device
-        //
-
-        Device (PRMB)
-        {
-            Name (_HID, "80860222")
-            Name (_CID, "80860222")
-            Name (_DDN, "PRM Bridge Device")
-            Name (_STA, 0xF)
-            OperationRegion (OPR1, 0x80, 0, 16)
-            Field (OPR1, DWordAcc, NoLock, Preserve) //Make it ByteAcc for parameter validation
-            {
-                Var0, 128
-            }
-            Method (SETV, 1, Serialized)
-            {
-                CopyObject (Arg0, \_SB.PRMB.Var0)
-            }
-        }
-
-        //
-        // PRM Test Device
-        //
-
-        Device (PRMT)
-        {
-            Name (_HID, "80860223")
-            Name (_CID, "80860223")
-            Name (_DDN, "PRM Test Device")
-            Name (_STA, 0xF)
-            Name (BUF1, Buffer(16)
-            {
-                0x5F, 0xAD, 0xF2, 0xD5, 0x47, 0xA3, 0x3E, 0x4D, //Guid_0
-                0x87, 0xBC, 0xC2, 0xCE, 0x63, 0x02, 0x9C, 0xC8, //Guid_1
-            })
-            Name (BUF2, Buffer(16)
-            {
-                0xC3, 0xAD, 0xE7, 0xA9, 0xD0, 0x8C, 0x9A, 0x42, //Guid_0
-                0x89, 0x15, 0x10, 0x94, 0x6E, 0xBD, 0xE3, 0x18, //Guid_1
-            })
-            Name (BUF3, Buffer(16)
-            {
-                0x14, 0xC2, 0x88, 0xB6, 0x81, 0x40, 0xEB, 0x4E, //Guid_0
-                0x8D, 0x26, 0x1E, 0xB5, 0xA3, 0xBC, 0xF1, 0x1A, //Guid_1
-            })
-            Method (NTST)
-            {
-                \_SB.PRMB.SETV (BUF1)
-            }
-            Method (TST1)
-            {
-                \_SB.PRMB.SETV (BUF1)
-            }
-            Method (TST2)
-            {
-                \_SB.PRMB.SETV (BUF2)
-            }
-            Method (TST3)
-            {
-                \_SB.PRMB.SETV (BUF3)
-            }
-        }
-    }
-
-} // End of Definition Block
-
-
-

PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c

@@ -20,7 +20,6 @@
 #include <Library/PrmContextBufferLib.h>
 #include <Library/UefiBootServicesTableLib.h>
 #include <Library/UefiLib.h>
-#include <Library/DxeServicesLib.h>
 #include <Protocol/AcpiTable.h>
 #include <Protocol/LoadedImage.h>
 #include <Protocol/PrmConfig.h>
@@ -811,8 +810,6 @@ PublishPrmAcpiTable (
   EFI_STATUS                              Status;
   EFI_ACPI_TABLE_PROTOCOL                 *AcpiTableProtocol;
   UINTN                                   TableKey;
-  EFI_ACPI_DESCRIPTION_HEADER             *Ssdt;
-  UINTN                                   SsdtSize;
 
   if (PrmAcpiDescriptionTable == NULL || PrmAcpiDescriptionTable->Header.Signature != PRM_TABLE_SIGNATURE) {
     return EFI_INVALID_PARAMETER;
@@ -836,36 +833,6 @@ PublishPrmAcpiTable (
   }
   ASSERT_EFI_ERROR (Status);
 
-  //
-  // Load SSDT
-  //
-  Status = GetSectionFromFv (
-               &gEfiCallerIdGuid,
-               EFI_SECTION_RAW,
-               0,
-               (VOID **) &Ssdt,
-               &SsdtSize
-               );
-  ASSERT_EFI_ERROR (Status);
-  DEBUG ((DEBUG_INFO, "%a %a: SSDT loaded ...\n", _DBGMSGID_, __FUNCTION__));
-
-  //
-  // Update OEM ID
-  //
-  CopyMem (&Ssdt->OemId, PcdGetPtr (PcdAcpiDefaultOemId), sizeof (Ssdt->OemId));
-
-  //
-  // Publish the SSDT. Table is re-checksumed.
-  //
-  TableKey = 0;
-  Status = AcpiTableProtocol->InstallAcpiTable (
-                        AcpiTableProtocol,
-                        Ssdt,
-                        SsdtSize,
-                        &TableKey
-                        );
-  ASSERT_EFI_ERROR (Status);
-
   return Status;
 }
 

PrmPkg/PrmLoaderDxe/PrmLoaderDxe.inf

@@ -24,7 +24,6 @@
   PrmAcpiTable.h
   PrmLoader.h
   PrmLoaderDxe.c
-  Prm.asl
 
 [Packages]
   MdePkg/MdePkg.dec
@@ -39,13 +38,12 @@
   BaseMemoryLib
   DebugLib
   MemoryAllocationLib
+  PcdLib
   PeCoffLib
   PrmContextBufferLib
   UefiBootServicesTableLib
   UefiDriverEntryPoint
   UefiLib
-  DxeServicesLib
-  PcdLib
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId            ## CONSUMES