Refine code to make it more safely.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong <eric.dong@intel.com> Reviewed-by: Feng Tian <feng.tian@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15598 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
/** @file
|
||||
Parser for IFR binary encoding.
|
||||
|
||||
Copyright (c) 2007 - 2013, Intel Corporation. All rights reserved.<BR>
|
||||
Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
|
||||
This program and the accompanying materials
|
||||
are licensed and made available under the terms and conditions of the BSD License
|
||||
which accompanies this distribution. The full text of the license may be found at
|
||||
@@ -663,6 +663,7 @@ InitializeRequestElement (
|
||||
ASSERT (ConfigInfo != NULL);
|
||||
ConfigInfo->Signature = FORM_BROWSER_CONFIG_REQUEST_SIGNATURE;
|
||||
ConfigInfo->ConfigRequest = AllocateCopyPool (StrSize (Storage->ConfigHdr), Storage->ConfigHdr);
|
||||
ASSERT (ConfigInfo->ConfigRequest != NULL);
|
||||
ConfigInfo->SpareStrLen = 0;
|
||||
ConfigInfo->Storage = Storage;
|
||||
InsertTailList(&Form->ConfigRequestHead, &ConfigInfo->Link);
|
||||
@@ -2327,6 +2328,7 @@ ParseOpCodes (
|
||||
break;
|
||||
|
||||
case EFI_IFR_ONE_OF_OPTION_OP:
|
||||
ASSERT (CurrentOption != NULL);
|
||||
ImageId = &CurrentOption->ImageId;
|
||||
break;
|
||||
|
||||
|
@@ -397,8 +397,11 @@ UpdateHotkeyList (
|
||||
HotKey = BROWSER_HOT_KEY_FROM_LINK (Link);
|
||||
|
||||
CopyKey = AllocateCopyPool(sizeof (BROWSER_HOT_KEY), HotKey);
|
||||
ASSERT (CopyKey != NULL);
|
||||
CopyKey->KeyData = AllocateCopyPool(sizeof (EFI_INPUT_KEY), HotKey->KeyData);
|
||||
ASSERT (CopyKey->KeyData != NULL);
|
||||
CopyKey->HelpString = AllocateCopyPool(StrSize (HotKey->HelpString), HotKey->HelpString);
|
||||
ASSERT (CopyKey->HelpString != NULL);
|
||||
|
||||
InsertTailList(&gDisplayFormData.HotKeyListHead, &CopyKey->Link);
|
||||
|
||||
@@ -1977,6 +1980,7 @@ ProcessCallBackFunction (
|
||||
if (Action == EFI_BROWSER_ACTION_CHANGING) {
|
||||
if (HiiValue->Type == EFI_IFR_TYPE_BUFFER) {
|
||||
BackUpBuffer = AllocateCopyPool(Statement->StorageWidth + sizeof(CHAR16), Statement->BufferValue);
|
||||
ASSERT (BackUpBuffer != NULL);
|
||||
} else {
|
||||
CopyMem (&BackUpValue, &HiiValue->Value, sizeof (EFI_IFR_TYPE_VALUE));
|
||||
}
|
||||
|
@@ -4060,8 +4060,11 @@ GetDefaultForFormset (
|
||||
}
|
||||
|
||||
TmpNode = AllocateCopyPool (sizeof (NAME_VALUE_NODE), Node);
|
||||
ASSERT (TmpNode != NULL);
|
||||
TmpNode->Name = AllocateCopyPool (StrSize(Node->Name) * sizeof (CHAR16), Node->Name);
|
||||
ASSERT (TmpNode->Name != NULL);
|
||||
TmpNode->EditValue = AllocateCopyPool (StrSize(Node->EditValue) * sizeof (CHAR16), Node->EditValue);
|
||||
ASSERT (TmpNode->EditValue != NULL);
|
||||
|
||||
InsertTailList(&BackUpList, &TmpNode->Link);
|
||||
}
|
||||
|
Reference in New Issue
Block a user